Issue 391603002: components: Add GN build files for three more components.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 391603002: components: Add GN build files for three more components. (Closed)

Created:
6 years, 5 months ago by tfarina

Modified:
6 years, 5 months ago

Reviewers:
brettw

CC:
chromium-reviews, tfarina, awong, jamesr, jochen (gone - plz use gerrit)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

components: Add GN build files for three more components. This patch adds BUILD files for: - enhanced_bookmarks - leveldb_proto - omaha_query_params BUG=None TEST=gn gen out/Debug_gn && ninja -C out/Debug_gn R=brettw@chromium.org TBR=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283234

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+121 lines, -7 lines)			Patch
M	components/BUILD.gn	View	1 2	1 chunk	+4 lines, -1 line	0 comments	Download
M	components/bookmarks/browser/BUILD.gn	View		1 chunk	+6 lines, -6 lines	0 comments	Download
A	components/enhanced_bookmarks/BUILD.gn	View		1 chunk	+45 lines, -0 lines	0 comments	Download
A	components/enhanced_bookmarks/proto/BUILD.gn	View		1 chunk	+11 lines, -0 lines	0 comments	Download
A	components/leveldb_proto/BUILD.gn	View	1	1 chunk	+28 lines, -0 lines	0 comments	Download
A	components/leveldb_proto/testing/proto/BUILD.gn	View		1 chunk	+11 lines, -0 lines	0 comments	Download
A	components/omaha_query_params/BUILD.gn	View		1 chunk	+16 lines, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/391603002/70001

6 years, 5 months ago (2014-07-15 00:57:34 UTC) #5

Message was sent while issue was closed.

Change committed as 283234