Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 391563002: Remove extension unload notification from LazyBackgroundLazyBackgroundTaskQueue (Closed)

Created:
6 years, 5 months ago by limasdf
Modified:
6 years, 5 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove extension unload notification from LazyBackgroundLazyBackgroundTaskQueue and use ExtensionRegistryObserver instead. BUG=354046 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283507

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -22 lines) Patch
M extensions/browser/lazy_background_task_queue.h View 1 2 5 chunks +14 lines, -1 line 0 comments Download
M extensions/browser/lazy_background_task_queue.cc View 1 2 chunks +19 lines, -21 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
limasdf
6 years, 5 months ago (2014-07-14 13:56:46 UTC) #1
Devlin
lgtm with 1 nit. https://codereview.chromium.org/391563002/diff/20001/extensions/browser/lazy_background_task_queue.h File extensions/browser/lazy_background_task_queue.h (right): https://codereview.chromium.org/391563002/diff/20001/extensions/browser/lazy_background_task_queue.h#newcode26 extensions/browser/lazy_background_task_queue.h:26: class ExtensionObserver; What is an ...
6 years, 5 months ago (2014-07-15 17:27:35 UTC) #2
limasdf
https://codereview.chromium.org/391563002/diff/20001/extensions/browser/lazy_background_task_queue.h File extensions/browser/lazy_background_task_queue.h (right): https://codereview.chromium.org/391563002/diff/20001/extensions/browser/lazy_background_task_queue.h#newcode26 extensions/browser/lazy_background_task_queue.h:26: class ExtensionObserver; On 2014/07/15 17:27:34, Devlin wrote: > What ...
6 years, 5 months ago (2014-07-16 05:44:59 UTC) #3
limasdf
The CQ bit was checked by limasdf@gmail.com
6 years, 5 months ago (2014-07-16 05:46:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/391563002/60001
6 years, 5 months ago (2014-07-16 05:48:48 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 21:15:25 UTC) #6
Message was sent while issue was closed. 
Change committed as 283507

Powered by Google App Engine
This is Rietveld 408576698