Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 391513002: Add easyUnlockPrivate extension API (Closed)

Created:
6 years, 5 months ago by tbarzic
Modified:
6 years, 5 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org, Ilya Sherman
Project:
chromium
Visibility:
Public.

Description

Add easyUnlockPrivate extension API The api will be used by Easy Unlock component app. Currently it contains methods needed for establishing secure communication channel on top of (unprotected) bluetooth. BUG=390230 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284637

Patch Set 1 #

Patch Set 2 : .' #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : add idl #

Patch Set 6 : . #

Patch Set 7 : . #

Total comments: 4

Patch Set 8 : histograms #

Total comments: 2

Patch Set 9 : . #

Patch Set 10 : . #

Patch Set 11 : rebase #

Patch Set 12 : . #

Patch Set 13 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+330 lines, -1 line) Patch
A + chrome/browser/extensions/api/easy_unlock_private/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.h View 1 chunk +90 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc View 1 chunk +88 lines, -0 lines 0 comments Download
M chrome/browser/resources/easy_unlock/manifest.json View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/_api_features.json View 1 2 3 4 5 6 7 8 9 10 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 2 3 4 5 6 7 8 9 10 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/api.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/api/easy_unlock_private.idl View 1 2 3 4 5 6 7 8 9 1 chunk +125 lines, -0 lines 0 comments Download
M chrome/common/extensions/permissions/chrome_api_permissions.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/permissions/permission_set_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/extension_function_histogram_value.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/common/permissions/api_permission.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
tbarzic
6 years, 5 months ago (2014-07-15 20:39:21 UTC) #1
Tim Song
https://codereview.chromium.org/391513002/diff/110001/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc File chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc (right): https://codereview.chromium.org/391513002/diff/110001/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc#newcode19 chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc:19: return false; Is this intentionally empty? https://codereview.chromium.org/391513002/diff/110001/extensions/browser/extension_function_histogram_value.h File extensions/browser/extension_function_histogram_value.h ...
6 years, 5 months ago (2014-07-15 23:37:56 UTC) #2
tbarzic
https://codereview.chromium.org/391513002/diff/110001/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc File chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc (right): https://codereview.chromium.org/391513002/diff/110001/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc#newcode19 chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc:19: return false; On 2014/07/15 23:37:56, Tim Song wrote: > ...
6 years, 5 months ago (2014-07-16 00:01:41 UTC) #3
Tim Song
lgtm
6 years, 5 months ago (2014-07-16 17:32:53 UTC) #4
asargent_no_longer_on_chrome
lgtm w/ one question https://codereview.chromium.org/391513002/diff/130001/chrome/common/extensions/api/_api_features.json File chrome/common/extensions/api/_api_features.json (right): https://codereview.chromium.org/391513002/diff/130001/chrome/common/extensions/api/_api_features.json#newcode281 chrome/common/extensions/api/_api_features.json:281: "contexts": ["blessed_extension", "unblessed_extension"] Do you ...
6 years, 5 months ago (2014-07-17 00:22:04 UTC) #5
tbarzic
https://codereview.chromium.org/391513002/diff/130001/chrome/common/extensions/api/_api_features.json File chrome/common/extensions/api/_api_features.json (right): https://codereview.chromium.org/391513002/diff/130001/chrome/common/extensions/api/_api_features.json#newcode281 chrome/common/extensions/api/_api_features.json:281: "contexts": ["blessed_extension", "unblessed_extension"] On 2014/07/17 00:22:04, Antony Sargent wrote: ...
6 years, 5 months ago (2014-07-18 22:50:22 UTC) #6
tbarzic
6 years, 5 months ago (2014-07-18 22:50:24 UTC) #7
tbarzic
Antony, could you have another look.. I ended up making some non-trivial changes (after realizing ...
6 years, 5 months ago (2014-07-18 22:53:09 UTC) #8
asargent_no_longer_on_chrome
new version lgtm
6 years, 5 months ago (2014-07-21 23:43:35 UTC) #9
tbarzic
+isherman for histograms
6 years, 5 months ago (2014-07-22 00:11:12 UTC) #10
Ilya Sherman
histograms lgtm
6 years, 5 months ago (2014-07-22 00:27:32 UTC) #11
tbarzic
The CQ bit was checked by tbarzic@chromium.org
6 years, 5 months ago (2014-07-22 00:29:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbarzic@chromium.org/391513002/210001
6 years, 5 months ago (2014-07-22 00:31:20 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-22 03:50:38 UTC) #14
tbarzic
The CQ bit was unchecked by tbarzic@chromium.org
6 years, 5 months ago (2014-07-22 03:58:20 UTC) #15
tbarzic
The CQ bit was checked by tbarzic@chromium.org
6 years, 5 months ago (2014-07-22 04:24:19 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbarzic@chromium.org/391513002/230001
6 years, 5 months ago (2014-07-22 04:24:43 UTC) #17
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 06:14:53 UTC) #18
Message was sent while issue was closed. 
Change committed as 284637

Powered by Google App Engine
This is Rietveld 408576698