[Bluetooth] Enforce that PSMs must be odd.

[Bluetooth] Enforce that PSMs must be odd (and otherwise well formed).

BUG=393414
TEST=browser_tests
R=keybuk@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283359

[Ilya Sherman, 2014-07-12 04:03:34]

keybuk for OWNERS review, others as FYI and extra eyes.

[keybuk, 2014-07-14 19:59:22]

On 2014/07/12 04:03:34, Ilya Sherman wrote:
> keybuk for OWNERS review, others as FYI and extra eyes.

The rules are a bit more complex than "must be odd", if we're going to enforce
them, we should enforce the correct rules:

• Protocol/Service Multiplexer - PSM (2 octets (minimum))
The PSM field is at least two octets in length. The structure of the PSM field
is based on the ISO 3309 extension mechanism for address fields. All PSM values
shall be ODD, that is, the least significant bit of the least significant octet
must be ’1’. Also, all PSM values shall have the least significant bit of the
most significant octet equal to ’0’. This allows the PSM field to be extended
beyond 16 bits. PSM values are separated into two ranges. Valid values in the
first range are assigned by the Bluetooth SIG and indicate pro- tocols. The
second range of values are dynamically allocated and used in conjunction with
the Service Discovery Protocol (SDP). The dynamically assigned values may be
used to support multiple implementations of a par- ticular protocol.
PSM values are defined in the Assigned Numbers document.


ie. 4113 is a valid PSM, but 4369 is not.

[Ilya Sherman, 2014-07-15 05:14:13]

On 2014/07/14 19:59:22, keybuk wrote:
> On 2014/07/12 04:03:34, Ilya Sherman wrote:
> > keybuk for OWNERS review, others as FYI and extra eyes.
> 
> The rules are a bit more complex than "must be odd", if we're going to enforce
> them, we should enforce the correct rules:
> 
> • Protocol/Service Multiplexer - PSM (2 octets (minimum))
> The PSM field is at least two octets in length. The structure of the PSM field
> is based on the ISO 3309 extension mechanism for address fields. All PSM
values
> shall be ODD, that is, the least significant bit of the least significant
octet
> must be ’1’. Also, all PSM values shall have the least significant bit of the
> most significant octet equal to ’0’. This allows the PSM field to be extended
> beyond 16 bits. PSM values are separated into two ranges. Valid values in the
> first range are assigned by the Bluetooth SIG and indicate pro- tocols. The
> second range of values are dynamically allocated and used in conjunction with
> the Service Discovery Protocol (SDP). The dynamically assigned values may be
> used to support multiple implementations of a par- ticular protocol.
> PSM values are defined in the Assigned Numbers document.
> 
> 
> ie. 4113 is a valid PSM, but 4369 is not.

Done.

[keybuk, 2014-07-15 20:40:48]

lgtm

[Ilya Sherman, 2014-07-15 20:41:03]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2014-07-15 20:45:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/isherman@chromium.org/391453002/20001

[commit-bot: I haz the power, 2014-07-16 05:35:55]

Change committed as 283359