Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 391423002: Generate makefile for bench_pictures. (Closed)

Created:
6 years, 5 months ago by scroggo
Modified:
6 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Generate makefile for bench_pictures. When generating Android framework makefiles, create one for bench_pictures. BUG=skia:2744 Committed: https://skia.googlesource.com/skia/+/3eb258d3f67cb78f3b0045857bb10e0774a55b41

Patch Set 1 #

Patch Set 2 : Include bench_pictures in the main makefile. #

Patch Set 3 : Make bench_pictures depend on skia. #

Total comments: 1

Patch Set 4 : Fix pylint errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -15 lines) Patch
M gyp/tools.gyp View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M platform_tools/android/bin/gyp_to_android.py View 1 chunk +9 lines, -0 lines 0 comments Download
M platform_tools/android/gyp_gen/makefile_writer.py View 1 2 3 2 chunks +16 lines, -15 lines 0 comments Download
M platform_tools/android/tests/expectations/Android.mk View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
scroggo
6 years, 5 months ago (2014-07-16 19:49:29 UTC) #1
scroggo
https://codereview.chromium.org/391423002/diff/40001/gyp/tools.gyp File gyp/tools.gyp (right): https://codereview.chromium.org/391423002/diff/40001/gyp/tools.gyp#newcode405 gyp/tools.gyp:405: 'libraries': [ '-lskia' ], mtklein pointed out live that ...
6 years, 5 months ago (2014-07-16 20:51:01 UTC) #2
djsollen
lgtm
6 years, 5 months ago (2014-07-17 13:16:35 UTC) #3
scroggo
The CQ bit was checked by scroggo@google.com
6 years, 5 months ago (2014-07-17 13:19:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/391423002/40001
6 years, 5 months ago (2014-07-17 13:19:33 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-17 13:19:36 UTC) #6
commit-bot: I haz the power
Presubmit check for 391423002-40001 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 5 months ago (2014-07-17 13:19:37 UTC) #7
scroggo
The CQ bit was checked by scroggo@google.com
6 years, 5 months ago (2014-07-17 13:23:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/391423002/60001
6 years, 5 months ago (2014-07-17 13:24:33 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 13:58:37 UTC) #10
Message was sent while issue was closed.
Change committed as 3eb258d3f67cb78f3b0045857bb10e0774a55b41

Powered by Google App Engine
This is Rietveld 408576698