Replace setup APIs with session APIs

Replace setup APIs with session APIs for GCD.

BUG=394441
R=asargent@chromium.org, asvitkine@chromium.org, vitalybuka@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284221

[Vitaly Buka (NO REVIEWS), 2014-07-16 18:49:13]

https://codereview.chromium.org/391413002/diff/1/chrome/common/extensions/api...
File chrome/common/extensions/api/gcd_private.idl (right):

https://codereview.chromium.org/391413002/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/gcd_private.idl:120: object message,
Could you please define message in idl?

https://codereview.chromium.org/391413002/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/gcd_private.idl:121: boolean populateWifiPassword,
why can't we remove "populateWifiPassword"
looks like we can always populate if field is not there

[Vitaly Buka (NO REVIEWS), 2014-07-16 18:50:38]

On 2014/07/16 18:49:13, Vitaly Buka wrote:
>
https://codereview.chromium.org/391413002/diff/1/chrome/common/extensions/api...
> File chrome/common/extensions/api/gcd_private.idl (right):
> 
>
https://codereview.chromium.org/391413002/diff/1/chrome/common/extensions/api...
> chrome/common/extensions/api/gcd_private.idl:120: object message,
> Could you please define message in idl?
> 
>
https://codereview.chromium.org/391413002/diff/1/chrome/common/extensions/api...
> chrome/common/extensions/api/gcd_private.idl:121: boolean
populateWifiPassword,
> why can't we remove "populateWifiPassword"
> looks like we can always populate if field is not there

we has some bug for API

[Noam Samuel, 2014-07-16 18:52:38]

https://codereview.chromium.org/391413002/diff/1/chrome/common/extensions/api...
File chrome/common/extensions/api/gcd_private.idl (right):

https://codereview.chromium.org/391413002/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/gcd_private.idl:120: object message,
On 2014/07/16 18:49:12, Vitaly Buka wrote:
> Could you please define message in idl?

I want to give the LAX team the flexibility to use this API to send other
messages in the protocol (e.g. info requests) as needed.

https://codereview.chromium.org/391413002/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/gcd_private.idl:121: boolean populateWifiPassword,
On 2014/07/16 18:49:12, Vitaly Buka wrote:
> why can't we remove "populateWifiPassword"
> looks like we can always populate if field is not there

Ditto.

[Noam Samuel, 2014-07-16 21:08:19]

https://codereview.chromium.org/391413002/diff/1/chrome/common/extensions/api...
File chrome/common/extensions/api/gcd_private.idl (right):

https://codereview.chromium.org/391413002/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/gcd_private.idl:120: object message,
On 2014/07/16 18:52:38, Noam Samuel wrote:
> On 2014/07/16 18:49:12, Vitaly Buka wrote:
> > Could you please define message in idl?
> 
> I want to give the LAX team the flexibility to use this API to send other
> messages in the protocol (e.g. info requests) as needed.

Split into api and input

https://codereview.chromium.org/391413002/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/gcd_private.idl:121: boolean populateWifiPassword,
On 2014/07/16 18:52:38, Noam Samuel wrote:
> On 2014/07/16 18:49:12, Vitaly Buka wrote:
> > why can't we remove "populateWifiPassword"
> > looks like we can always populate if field is not there
> 
> Ditto.

OK, done

[Vitaly Buka (NO REVIEWS), 2014-07-16 21:10:25]

lgtm

https://codereview.chromium.org/391413002/diff/20001/chrome/common/extensions...
File chrome/common/extensions/api/gcd_private.idl (right):

https://codereview.chromium.org/391413002/diff/20001/chrome/common/extensions...
chrome/common/extensions/api/gcd_private.idl:118: // |prefetchWifiPassword| will
be used and the call will fail if it's not
doc about prefetchWifiPassword still here

[Alexei Svitkine (slow), 2014-07-16 21:17:48]

https://codereview.chromium.org/391413002/diff/20001/extensions/browser/exten...
File extensions/browser/extension_function_histogram_value.h (right):

https://codereview.chromium.org/391413002/diff/20001/extensions/browser/exten...
extensions/browser/extension_function_histogram_value.h:886:
GCDPRIVATE_PREFETCHWIFIPASSWORD,
Please don't re-use existing ids. Otherwise, it's confusing when you look at an
aggregated view (that includes multiple versions) about what the fields refer
to.

Instead, mark the old ones as DELETED_ and add the new ones at the end.

Also, update histograms.xml.

[Vitaly Buka (NO REVIEWS), 2014-07-16 21:48:07]

On 2014/07/16 21:17:48, Alexei Svitkine wrote:
>
https://codereview.chromium.org/391413002/diff/20001/extensions/browser/exten...
> File extensions/browser/extension_function_histogram_value.h (right):
> 
>
https://codereview.chromium.org/391413002/diff/20001/extensions/browser/exten...
> extensions/browser/extension_function_histogram_value.h:886:
> GCDPRIVATE_PREFETCHWIFIPASSWORD,
> Please don't re-use existing ids. Otherwise, it's confusing when you look at
an
> aggregated view (that includes multiple versions) about what the fields refer
> to.
> 
> Instead, mark the old ones as DELETED_ and add the new ones at the end.
> 
> Also, update histograms.xml.

we don't have data yet

[Alexei Svitkine (slow), 2014-07-17 15:48:46]

On 2014/07/16 21:48:07, Vitaly Buka wrote:
> On 2014/07/16 21:17:48, Alexei Svitkine wrote:
> >
>
https://codereview.chromium.org/391413002/diff/20001/extensions/browser/exten...
> > File extensions/browser/extension_function_histogram_value.h (right):
> > 
> >
>
https://codereview.chromium.org/391413002/diff/20001/extensions/browser/exten...
> > extensions/browser/extension_function_histogram_value.h:886:
> > GCDPRIVATE_PREFETCHWIFIPASSWORD,
> > Please don't re-use existing ids. Otherwise, it's confusing when you look at
> an
> > aggregated view (that includes multiple versions) about what the fields
refer
> > to.
> > 
> > Instead, mark the old ones as DELETED_ and add the new ones at the end.
> > 
> > Also, update histograms.xml.
> 
> we don't have data yet

Okay, but you still need to update histograms.xml.

[Noam Samuel, 2014-07-17 17:48:34]

On 2014/07/17 15:48:46, Alexei Svitkine wrote:
> On 2014/07/16 21:48:07, Vitaly Buka wrote:
> > On 2014/07/16 21:17:48, Alexei Svitkine wrote:
> > >
> >
>
https://codereview.chromium.org/391413002/diff/20001/extensions/browser/exten...
> > > File extensions/browser/extension_function_histogram_value.h (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/391413002/diff/20001/extensions/browser/exten...
> > > extensions/browser/extension_function_histogram_value.h:886:
> > > GCDPRIVATE_PREFETCHWIFIPASSWORD,
> > > Please don't re-use existing ids. Otherwise, it's confusing when you look
at
> > an
> > > aggregated view (that includes multiple versions) about what the fields
> refer
> > > to.
> > > 
> > > Instead, mark the old ones as DELETED_ and add the new ones at the end.
> > > 
> > > Also, update histograms.xml.
> > 
> > we don't have data yet
> 
> Okay, but you still need to update histograms.xml.

Updated

[Alexei Svitkine (slow), 2014-07-17 17:53:00]

lgtm

[asargent_no_longer_on_chrome, 2014-07-18 17:18:31]

lgtm

https://codereview.chromium.org/391413002/diff/40001/chrome/common/extensions...
File chrome/common/extensions/api/gcd_private.idl (right):

https://codereview.chromium.org/391413002/diff/40001/chrome/common/extensions...
chrome/common/extensions/api/gcd_private.idl:43: success
style nit: it's a little easier to read both the comments and enum member names
if there is a space between them, e.g.


  // comment
  foo,

  // comment
  bar


like we have it above in the GCDDevice dictionary.

https://codereview.chromium.org/391413002/diff/40001/chrome/common/extensions...
chrome/common/extensions/api/gcd_private.idl:77: // Called to indicated the
session is established.
nit: add space above this line (next two functions also)

[Noam Samuel, 2014-07-18 17:56:46]

https://codereview.chromium.org/391413002/diff/40001/chrome/common/extensions...
File chrome/common/extensions/api/gcd_private.idl (right):

https://codereview.chromium.org/391413002/diff/40001/chrome/common/extensions...
chrome/common/extensions/api/gcd_private.idl:43: success
On 2014/07/18 17:18:31, Antony Sargent wrote:
> style nit: it's a little easier to read both the comments and enum member
names
> if there is a space between them, e.g.
> 
> 
>   // comment
>   foo,
> 
>   // comment
>   bar
> 
> 
> like we have it above in the GCDDevice dictionary.

Done.

https://codereview.chromium.org/391413002/diff/40001/chrome/common/extensions...
chrome/common/extensions/api/gcd_private.idl:77: // Called to indicated the
session is established.
On 2014/07/18 17:18:31, Antony Sargent wrote:
> nit: add space above this line (next two functions also)

Done.

[Noam Samuel, 2014-07-18 17:56:50]

The CQ bit was checked by noamsml@chromium.org

[commit-bot: I haz the power, 2014-07-18 17:58:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/noamsml@chromium.org/391413002/60001

[commit-bot: I haz the power, 2014-07-18 21:19:35]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[commit-bot: I haz the power, 2014-07-18 21:54:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-18 21:54:02]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[Noam Samuel, 2014-07-18 22:21:04]

Committed patchset #5 manually as r284221 (presubmit successful).