Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Issue 391393002: Fix for uninitialized access. (Closed)

Created:
6 years, 5 months ago by aiolos (Not reviewing)
Modified:
6 years, 5 months ago
Reviewers:
mmenke, davidben, earthdok
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix for uninitialized access. BUG=394390 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283760

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix initilization ordering. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -4 lines) Patch
M content/browser/loader/resource_scheduler.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/loader/resource_scheduler_unittest.cc View 27 chunks +78 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
aiolos (Not reviewing)
6 years, 5 months ago (2014-07-16 17:06:53 UTC) #1
mmenke
LGTM. I did the exact same thing in another CL a week or two ago. ...
6 years, 5 months ago (2014-07-16 17:37:02 UTC) #2
aiolos (Not reviewing)
The CQ bit was checked by aiolos@chromium.org
6 years, 5 months ago (2014-07-16 17:40:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aiolos@chromium.org/391393002/1
6 years, 5 months ago (2014-07-16 17:42:51 UTC) #4
earthdok
On 2014/07/16 17:42:51, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 5 months ago (2014-07-16 18:22:08 UTC) #5
earthdok
On 2014/07/16 18:22:08, earthdok wrote: > On 2014/07/16 17:42:51, I haz the power (commit-bot) wrote: ...
6 years, 5 months ago (2014-07-16 18:34:44 UTC) #6
mmenke
On 2014/07/16 18:34:44, earthdok wrote: > On 2014/07/16 18:22:08, earthdok wrote: > > On 2014/07/16 ...
6 years, 5 months ago (2014-07-16 18:40:19 UTC) #7
aiolos (Not reviewing)
On 2014/07/16 18:40:19, mmenke wrote: > On 2014/07/16 18:34:44, earthdok wrote: > > On 2014/07/16 ...
6 years, 5 months ago (2014-07-16 19:18:00 UTC) #8
aiolos (Not reviewing)
The CQ bit was checked by aiolos@chromium.org
6 years, 5 months ago (2014-07-16 19:18:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aiolos@chromium.org/391393002/2
6 years, 5 months ago (2014-07-16 19:19:44 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 22:06:28 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-17 02:39:06 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/39694)
6 years, 5 months ago (2014-07-17 02:39:07 UTC) #13
earthdok
The CQ bit was checked by earthdok@chromium.org
6 years, 5 months ago (2014-07-17 10:14:38 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aiolos@chromium.org/391393002/2
6 years, 5 months ago (2014-07-17 10:17:05 UTC) #15
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 12:10:51 UTC) #16
Message was sent while issue was closed.
Change committed as 283760

Powered by Google App Engine
This is Rietveld 408576698