Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 391383004: Revert of athena: Add a minimized state for the home-card. (Closed)

Created:
6 years, 5 months ago by kuan
Modified:
6 years, 5 months ago
Reviewers:
oshima, Jun Mukai, sadrul
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Revert of athena: Add a minimized state for the home-card. (https://codereview.chromium.org/394043002/) Reason for revert: it broke "athena_unittests,steps" on "Linux ChromiumOS Tests (1)": http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/45720. Original issue's description: > athena: Add a minimized state for the home-card. > > The home-card can be in a minimized state. In this state, only a narrow line > is displayed at the bottom of the screen, and dragging it up shows the overview > mode. When a window is selected in the overview mode, the home-card is minimized > again. > > BUG=381224 > R=mukai@chromium.org, oshima@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283539 TBR=mukai@chromium.org,oshima@chromium.org,sadrul@chromium.org NOTREECHECKS=true NOTRY=true BUG=381224 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283564

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -325 lines) Patch
M athena/athena.gyp View 2 chunks +0 lines, -3 lines 0 comments Download
M athena/home/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M athena/home/home_card_impl.cc View 8 chunks +28 lines, -125 lines 0 comments Download
D athena/home/minimized_home.h View 1 chunk +0 lines, -32 lines 0 comments Download
D athena/home/minimized_home.cc View 1 chunk +0 lines, -100 lines 0 comments Download
M athena/home/public/home_card.h View 2 chunks +1 line, -6 lines 0 comments Download
M athena/wm/public/window_manager.h View 2 chunks +0 lines, -6 lines 0 comments Download
D athena/wm/public/window_manager_observer.h View 1 chunk +0 lines, -25 lines 0 comments Download
M athena/wm/window_manager_impl.cc View 5 chunks +2 lines, -27 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kuan
Created Revert of athena: Add a minimized state for the home-card.
6 years, 5 months ago (2014-07-16 23:04:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kuan@chromium.org/391383004/1
6 years, 5 months ago (2014-07-16 23:07:25 UTC) #2
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 23:12:02 UTC) #3
Message was sent while issue was closed.
Change committed as 283564

Powered by Google App Engine
This is Rietveld 408576698