Issue 391373008: DevTools: Show JS callstacks on tracing-based timeline

Issue 391373008: DevTools: Show JS callstacks on tracing-based timeline (Closed)

Created:
6 years, 5 months ago by alph

Modified:
6 years, 5 months ago

Reviewers:
caseq, yurys, loislo

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: Show JS callstacks on tracing-based timeline BUG=361045 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178383

Patch Set 1 #

Total comments: 6

Patch Set 2 : Addressing comments #

Patch Set 3 : Moved JSFrame events from model to the flame chart data provider. #

Patch Set 4 : Added JSDoc #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -10 lines)			Patch
	M	Source/devtools/front_end/timeline/TimelineFlameChart.js	View	1 2 3	6 chunks	+50 lines, -8 lines	0 comments	Download
	M	Source/devtools/front_end/timeline/TracingTimelineUIUtils.js	View	1 2	2 chunks	+10 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

yurys

lgtm https://codereview.chromium.org/391373008/diff/1/Source/devtools/front_end/timeline/TimelineFlameChart.js File Source/devtools/front_end/timeline/TimelineFlameChart.js (right): https://codereview.chromium.org/391373008/diff/1/Source/devtools/front_end/timeline/TimelineFlameChart.js#newcode464 Source/devtools/front_end/timeline/TimelineFlameChart.js:464: WebInspector.TracingBasedTimelineFlameChartDataProvider.InstantEventVisibleDuration = 0.01; InstantEventVisibleDurationMs https://codereview.chromium.org/391373008/diff/1/Source/devtools/front_end/timeline/TracingModel.js File Source/devtools/front_end/timeline/TracingModel.js (right): ...

6 years, 5 months ago (2014-07-17 14:32:40 UTC) #2

alph

https://codereview.chromium.org/391373008/diff/1/Source/devtools/front_end/timeline/TimelineFlameChart.js File Source/devtools/front_end/timeline/TimelineFlameChart.js (right): https://codereview.chromium.org/391373008/diff/1/Source/devtools/front_end/timeline/TimelineFlameChart.js#newcode464 Source/devtools/front_end/timeline/TimelineFlameChart.js:464: WebInspector.TracingBasedTimelineFlameChartDataProvider.InstantEventVisibleDuration = 0.01; On 2014/07/17 14:32:40, yurys wrote: > ...

6 years, 5 months ago (2014-07-17 15:48:43 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alph@chromium.org/391373008/60001

6 years, 5 months ago (2014-07-17 15:54:07 UTC) #5

Message was sent while issue was closed.

Change committed as 178383

Expand Messages | Collapse Messages