Refactoring : Move AuthAttempt and Authenticators to chromeos/login

Refactoring : Move AuthAttempt and Authenticators to chromeos/login
Extracted LoginEventRecorder from BootTimesLoader to loose dependecies.

BUG=387613
R=nkostylev@chromium.org
TBR=bauerb@chromium.org
TBR=stevenjb@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284682

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285137

[Denis Kuznetsov (DE-MUC), 2014-07-16 16:17:07]

TBR for rubber-stamping:
Steven as owner of chromeos/ root
Bernhard as owener of chrome/browser/supervised_user/

[Bernhard Bauer, 2014-07-16 16:26:49]

c/b/supervised_user/ trivially LGTM.

[Nikita (slow), 2014-07-16 16:57:45]

lgtm

https://chromiumcodereview.appspot.com/391373002/diff/20001/chromeos/login_ev...
File chromeos/login_event_recorder.h (right):

https://chromiumcodereview.appspot.com/391373002/diff/20001/chromeos/login_ev...
chromeos/login_event_recorder.h:15: // BootTimesLoader loads the bootimes of
Chrome OS from the file system.
nit: Comments needs to be updated.

[Denis Kuznetsov (DE-MUC), 2014-07-21 18:02:33]

The CQ bit was checked by antrim@chromium.org

[commit-bot: I haz the power, 2014-07-21 18:04:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/antrim@chromium.org/391373002/40001

[commit-bot: I haz the power, 2014-07-21 19:49:52]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/35505)

[commit-bot: I haz the power, 2014-07-21 20:58:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-21 20:58:35]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[Denis Kuznetsov (DE-MUC), 2014-07-22 10:28:26]

The CQ bit was checked by antrim@chromium.org

[commit-bot: I haz the power, 2014-07-22 10:30:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/antrim@chromium.org/391373002/40001

[commit-bot: I haz the power, 2014-07-22 10:36:25]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-22 10:46:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-22 10:46:06]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[Denis Kuznetsov (DE-MUC), 2014-07-22 11:28:12]

The CQ bit was checked by antrim@chromium.org

[commit-bot: I haz the power, 2014-07-22 11:29:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/antrim@chromium.org/391373002/60001

[Denis Kuznetsov (DE-MUC), 2014-07-22 11:29:26]

The CQ bit was unchecked by antrim@chromium.org

[Denis Kuznetsov (DE-MUC), 2014-07-22 11:30:01]

The CQ bit was checked by antrim@chromium.org

[commit-bot: I haz the power, 2014-07-22 11:31:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/antrim@chromium.org/391373002/80001

[commit-bot: I haz the power, 2014-07-22 13:12:19]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-07-22 15:52:42]

Change committed as 284682

[stevenjb, 2014-07-22 16:38:43]

So, I am thrilled that we are moving login code out of src/chrome, and for the
bits with no UI dependencies src/chromeos/login is the right place for them, but
we need to remove the BrowserThread dependencies. I gave some examples in
https://chromiumcodereview.appspot.com/402403004/ of how we have done this in
other places.

Thanks!
-Steven

https://codereview.chromium.org/391373002/diff/80001/chromeos/login/DEPS
File chromeos/login/DEPS (right):

https://codereview.chromium.org/391373002/diff/80001/chromeos/login/DEPS#newc...
chromeos/login/DEPS:3: "+content/public/browser",
This is a layering violation. Please see my comments in
https://chromiumcodereview.appspot.com/402403004/.

https://codereview.chromium.org/391373002/diff/80001/chromeos/login/auth/auth...
File chromeos/login/auth/auth_attempt_state.cc (right):

https://codereview.chromium.org/391373002/diff/80001/chromeos/login/auth/auth...
chromeos/login/auth/auth_attempt_state.cc:9: #include
"content/public/browser/browser_thread.h"
Layering violation.

https://codereview.chromium.org/391373002/diff/80001/chromeos/login/auth/exte...
File chromeos/login/auth/extended_authenticator.cc (right):

https://codereview.chromium.org/391373002/diff/80001/chromeos/login/auth/exte...
chromeos/login/auth/extended_authenticator.cc:20: #include
"content/public/browser/browser_thread.h"
Layering violation.

https://codereview.chromium.org/391373002/diff/80001/chromeos/login/auth/mock...
File chromeos/login/auth/mock_authenticator.cc (right):

https://codereview.chromium.org/391373002/diff/80001/chromeos/login/auth/mock...
chromeos/login/auth/mock_authenticator.cc:9: #include
"content/public/browser/browser_thread.h"
Layering violation.

[johnme, 2014-07-22 17:19:17]

A revert of this CL has been created in
https://codereview.chromium.org/413473003/ by johnme@chromium.org.

The reason for reverting is: I'm afraid the BrowserThread layering violations in
this patch actually cause compile failures on:

http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tes...

http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tes....

[Denis Kuznetsov (DE-MUC), 2014-07-23 17:34:11]

https://codereview.chromium.org/391373002/diff/80001/chromeos/login/DEPS
File chromeos/login/DEPS (right):

https://codereview.chromium.org/391373002/diff/80001/chromeos/login/DEPS#newc...
chromeos/login/DEPS:3: "+content/public/browser",
On 2014/07/22 16:38:43, stevenjb wrote:
> This is a layering violation. Please see my comments in
> https://chromiumcodereview.appspot.com/402403004/.

Done.

https://codereview.chromium.org/391373002/diff/80001/chromeos/login/auth/auth...
File chromeos/login/auth/auth_attempt_state.cc (right):

https://codereview.chromium.org/391373002/diff/80001/chromeos/login/auth/auth...
chromeos/login/auth/auth_attempt_state.cc:9: #include
"content/public/browser/browser_thread.h"
On 2014/07/22 16:38:43, stevenjb wrote:
> Layering violation.

Done.

https://codereview.chromium.org/391373002/diff/80001/chromeos/login/auth/exte...
File chromeos/login/auth/extended_authenticator.cc (right):

https://codereview.chromium.org/391373002/diff/80001/chromeos/login/auth/exte...
chromeos/login/auth/extended_authenticator.cc:20: #include
"content/public/browser/browser_thread.h"
On 2014/07/22 16:38:43, stevenjb wrote:
> Layering violation.

Done.

https://codereview.chromium.org/391373002/diff/80001/chromeos/login/auth/mock...
File chromeos/login/auth/mock_authenticator.cc (right):

https://codereview.chromium.org/391373002/diff/80001/chromeos/login/auth/mock...
chromeos/login/auth/mock_authenticator.cc:9: #include
"content/public/browser/browser_thread.h"
On 2014/07/22 16:38:43, stevenjb wrote:
> Layering violation.

Done.

[Denis Kuznetsov (DE-MUC), 2014-07-23 17:34:40]

The CQ bit was checked by antrim@chromium.org

[commit-bot: I haz the power, 2014-07-23 17:35:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/antrim@chromium.org/391373002/100001

[commit-bot: I haz the power, 2014-07-23 18:27:26]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/9...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/20...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel_swarming on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_sw...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win8_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/bui...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/32168)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/37082)

[commit-bot: I haz the power, 2014-07-23 18:29:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-23 18:29:56]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/32203)

[Denis Kuznetsov (DE-MUC), 2014-07-23 19:05:41]

The CQ bit was checked by antrim@chromium.org

[commit-bot: I haz the power, 2014-07-23 19:06:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/antrim@chromium.org/391373002/120001

[commit-bot: I haz the power, 2014-07-23 21:59:11]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-24 03:15:31]

Change committed as 285137