Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 391363005: [DevTools] Initialize WebContents size at the start to speed-up loading. (Closed)

Created:
6 years, 5 months ago by dgozman
Modified:
6 years, 5 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Project:
chromium
Visibility:
Public.

Description

[DevTools] Initialize WebContents size at the start to speed-up loading. This has visible effect on the Mac, where WebContents has zero size initially. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284223

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M chrome/browser/devtools/devtools_window.cc View 2 chunks +17 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dgozman
Take a look please.
6 years, 5 months ago (2014-07-17 14:51:34 UTC) #1
pfeldman
lgtm
6 years, 5 months ago (2014-07-18 16:08:45 UTC) #2
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 5 months ago (2014-07-18 18:11:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/391363005/1
6 years, 5 months ago (2014-07-18 18:14:03 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-18 20:49:08 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 22:27:17 UTC) #6
Message was sent while issue was closed.
Change committed as 284223

Powered by Google App Engine
This is Rietveld 408576698