Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(844)

Unified Diff: chrome/browser/ui/views/autofill/autofill_popup_base_view.cc

Issue 391343010: Revert r283051: Fix positioning of Autofill popups (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/autofill/autofill_popup_base_view.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/autofill/autofill_popup_base_view.cc
diff --git a/chrome/browser/ui/views/autofill/autofill_popup_base_view.cc b/chrome/browser/ui/views/autofill/autofill_popup_base_view.cc
index 861718b8e1edad875a91246c39e0c12d212e4b97..ced38990ff6767f987a1b1b0563574168d155d8c 100644
--- a/chrome/browser/ui/views/autofill/autofill_popup_base_view.cc
+++ b/chrome/browser/ui/views/autofill/autofill_popup_base_view.cc
@@ -63,7 +63,7 @@ void AutofillPopupBaseView::DoShow() {
views::Widget* widget = new views::Widget;
views::Widget::InitParams params(views::Widget::InitParams::TYPE_POPUP);
params.delegate = this;
- params.context = container_view();
+ params.parent = container_view();
widget->Init(params);
widget->SetContentsView(this);
@@ -102,10 +102,8 @@ void AutofillPopupBaseView::DoHide() {
}
void AutofillPopupBaseView::RemoveObserver() {
- if (observing_widget_) {
- observing_widget_->GetFocusManager()->UnregisterAccelerators(this);
- observing_widget_->RemoveObserver(this);
- }
+ observing_widget_->GetFocusManager()->UnregisterAccelerators(this);
+ observing_widget_->RemoveObserver(this);
views::WidgetFocusManager::GetInstance()->RemoveFocusChangeListener(this);
}
@@ -121,11 +119,6 @@ void AutofillPopupBaseView::OnNativeFocusChange(
HideController();
}
-void AutofillPopupBaseView::OnWidgetDestroying(views::Widget* widget) {
- DCHECK_EQ(widget, observing_widget_);
- observing_widget_ = NULL;
-}
-
void AutofillPopupBaseView::OnWidgetBoundsChanged(views::Widget* widget,
const gfx::Rect& new_bounds) {
DCHECK_EQ(widget, observing_widget_);
« no previous file with comments | « chrome/browser/ui/views/autofill/autofill_popup_base_view.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698