Issue 391343010: Revert r283051: Fix positioning of Autofill popups

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 391343010: Revert r283051: Fix positioning of Autofill popups (Closed)

Created:
6 years, 5 months ago by Evan Stade

Modified:
6 years, 5 months ago

Reviewers:
sky

CC:
chromium-reviews, benquan, tfarina, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org, calamity

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert r283051: Fix positioning of Autofill popups patch broke windows BUG=391316, 394666 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283982

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -11 lines)			Patch
	M	chrome/browser/ui/views/autofill/autofill_popup_base_view.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	chrome/browser/ui/views/autofill/autofill_popup_base_view.cc	View		3 chunks	+3 lines, -10 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

git bisect is broken, so I couldn't figure out what caused the original bug crbug.com/391316 ...

6 years, 5 months ago (2014-07-17 18:38:25 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/391343010/1

6 years, 5 months ago (2014-07-17 19:44:11 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...

6 years, 5 months ago (2014-07-18 00:55:33 UTC) #5

Message was sent while issue was closed.

Change committed as 283982

Expand Messages | Collapse Messages