Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 391343006: Pepper: Remove some gyp defines for trusted plugin. (Closed)

Created:
6 years, 5 months ago by teravest
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Pepper: Remove some gyp defines for trusted plugin. As far as I can tell, these defines shouldn't have any effect. I'd like to make the trusted plugin build more similar to what we have for the renderer so that the transition will be easier when we get rid of the trusted plugin shared library. This mirrors a change made to native_client in 2012: http://git.chromium.org/gitweb/?p=native_client/src/native_client.git;a=commitdiff;h=c0a9077e3a604521f67f35c9bec3be031dd21465 BUG=394497 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283668

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M ppapi/native_client/src/trusted/plugin/plugin.gypi View 3 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
teravest
6 years, 5 months ago (2014-07-16 21:33:09 UTC) #1
Nick Bray (chromium)
LGTM
6 years, 5 months ago (2014-07-16 21:58:29 UTC) #2
teravest
The CQ bit was checked by teravest@chromium.org
6 years, 5 months ago (2014-07-16 22:16:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/391343006/1
6 years, 5 months ago (2014-07-16 22:19:49 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 06:46:37 UTC) #5
Message was sent while issue was closed.
Change committed as 283668

Powered by Google App Engine
This is Rietveld 408576698