Pepper: add Image Capture interfaces.

ppapi/c/private/ppb_camera_capabilities_private.h

Index: ppapi/c/private/ppb_camera_capabilities_private.h
diff --git a/ppapi/c/private/ppb_camera_capabilities_private.h b/ppapi/c/private/ppb_camera_capabilities_private.h
new file mode 100644
index 0000000000000000000000000000000000000000..2a70b3668cdbc30c7379d29d41dbf7e81507ed0e
--- /dev/null
+++ b/ppapi/c/private/ppb_camera_capabilities_private.h
@@ -0,0 +1,92 @@
+/* Copyright (c) 2014 The Chromium Authors. All rights reserved.
+ * Use of this source code is governed by a BSD-style license that can be
+ * found in the LICENSE file.
+ */
+
+/* From private/ppb_camera_capabilities_private.idl,
+ *   modified Thu Aug  7 17:22:52 2014.
+ */
+
+#ifndef PPAPI_C_PRIVATE_PPB_CAMERA_CAPABILITIES_PRIVATE_H_
+#define PPAPI_C_PRIVATE_PPB_CAMERA_CAPABILITIES_PRIVATE_H_
+
+#include "ppapi/c/pp_bool.h"
+#include "ppapi/c/pp_macros.h"
+#include "ppapi/c/pp_resource.h"
+#include "ppapi/c/pp_size.h"
+#include "ppapi/c/pp_stdint.h"
+
+#define PPB_CAMERACAPABILITIES_PRIVATE_INTERFACE_0_1 \
+    "PPB_CameraCapabilities_Private;0.1"
+#define PPB_CAMERACAPABILITIES_PRIVATE_INTERFACE \
+    PPB_CAMERACAPABILITIES_PRIVATE_INTERFACE_0_1
+
+/**
+ * @file
+ * This file defines the PPB_CameraCapabilities_Private interface for
+ * establishing an image capture configuration resource within the browser.
+ */
+
+
+/**
+ * @addtogroup Interfaces
+ * @{
+ */
+/**
+ * The <code>PPB_CameraCapabilities_Private</code> interface contains pointers
+ * to several functions for getting the image capture capabilities within the
+ * browser.
+ */
+struct PPB_CameraCapabilities_Private_0_1 {
+  /**
+   * IsCameraCapabilities() determines if the given resource is a
+   * <code>PPB_CameraCapabilities_Private</code>.
+   *
+   * @param[in] resource A <code>PP_Resource</code> corresponding to an image
+   * capture capabilities resource.
+   *
+   * @return A <code>PP_Bool</code> containing <code>PP_TRUE</code> if the given
+   * resource is an <code>PP_CameraCapabilities_Private</code> resource,
+   * otherwise <code>PP_FALSE</code>.
+   */
+  PP_Bool (*IsCameraCapabilities)(PP_Resource resource);
+  /**
+   * GetSupportedPreviewSizes(

[Justin Chuang, 2014/08/11 08:32:35]

nit: spurious newline?

[wuchengli, 2014/08/12 07:27:02]

This is auto-generated. We should not change the file manually. I don't want to
fix IDL generator. :)

+      ) returns the supported preview sizes for the given
+   * <code>PPB_CameraCapabilities_Private</code>.
+   *
+   * @param[in] capabilities A <code>PP_Resource</code> corresponding to an
+   * image capture capabilities resource.
+   * @param[out] array_size The size of preview size array.
+   * @param[out] An array of <code>PP_Size</code> corresponding to the supported
+   * preview sizes in pixels. The ownership of the array belongs to <code>
+   * PPB_CameraCapabilities_Private</code> and the caller should not free it.
+   */
+  void (*GetSupportedPreviewSizes)(PP_Resource capabilities,
+                                   int32_t* array_size,
+                                   struct PP_Size* preview_sizes[]);

[Justin Chuang, 2014/08/11 08:32:35]

From the comments, the returned array should belong to
PPB_CameraCapabilities_Private, but from the generated prototype, it actually
means the caller owns and prepares "an array of pointers" (caller prepares a
PP_Size* []), then pass the array of pointer to this API.) It's not what we
want.

I guess you want to generate something like: 

     const struct PP_Size **preview_sizes

Then the caller only needs to prepare a pointer. 

(Otherwise, C++ can pass reference to an array in return value, but I doubt the
idl generator can do that.)

[wuchengli, 2014/08/12 07:27:02]

I found idl generator did not support this. I've changed to a null-terminated
array of pointer to PP_Size. It's similar to
PPP_Flash_BrowserOperations.GetSitesWithData().
https://code.google.com/p/chromium/codesearch#chromium/src/ppapi/api/private/...

+  /**
+   * GetSupportedJpegSize() returns the supported JPEG sizes for the given
+   * <code>PPB_CameraCapabilities_Private</code>.
+   *
+   * @param[in] capabilities A <code>PP_Resource</code> corresponding to an
+   * image capture capabilities resource.
+   * @param[out] array_size The size of JPEG size array. If the output of this
+   * is 0, the camera has no support for generating JPEG images.
+   * @param[out] An array of <code>PP_Size</code> corresponding to the supported
+   * JPEG image sizes in pixels. The ownership of the array belongs to <code>
+   * PPB_CameraCapabilities_Private</code> and the caller should not free it.
+   */
+  void (*GetSupportedJpegSizes)(PP_Resource capabilities,
+                                int32_t* array_size,
+                                struct PP_Size* jpeg_sizes[]);
+};
+
+typedef struct PPB_CameraCapabilities_Private_0_1
+    PPB_CameraCapabilities_Private;
+/**
+ * @}
+ */
+
+#endif  /* PPAPI_C_PRIVATE_PPB_CAMERA_CAPABILITIES_PRIVATE_H_ */
+