Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 391313003: Files.app: mpeg metadata parser must not be stateful. (Closed)

Created:
6 years, 5 months ago by kinaba
Modified:
6 years, 5 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Files.app: mpeg metadata parser must not be stateful. The previous code writes the parsed metadata to |metadata| dictionary remembered in |this.rootParser_|, but this is wrong. The parser class is shared among multiple parses, so to correctly distinguish concurrent parsing activity, it cannot store states in the member fields. BUG=172989 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283545

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M ui/file_manager/file_manager/foreground/js/metadata/mpeg_parser.js View 7 chunks +12 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
kinaba
6 years, 5 months ago (2014-07-16 07:30:25 UTC) #1
yoshiki
lgtm
6 years, 5 months ago (2014-07-16 10:45:49 UTC) #2
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 5 months ago (2014-07-16 11:06:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/391313003/1
6 years, 5 months ago (2014-07-16 11:08:57 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 14:11:51 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-16 14:30:39 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/171466)
6 years, 5 months ago (2014-07-16 14:30:40 UTC) #7
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 5 months ago (2014-07-16 15:43:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/391313003/1
6 years, 5 months ago (2014-07-16 15:44:59 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 22:19:10 UTC) #10
Message was sent while issue was closed.
Change committed as 283545

Powered by Google App Engine
This is Rietveld 408576698