Issue 391283002: Add content_common dependency to app_shim target

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 391283002: Add content_common dependency to app_shim target (Closed)

Created:
6 years, 5 months ago by tkent

Modified:
6 years, 5 months ago

Reviewers:
tapted, jamesr

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Add content_common dependency to app_shim target This is necessary because extension_app_shim_handler_mac.cc includes public/web/WebNotificationPresenter.h indirectly. BUG=350097 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283496

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	apps/app_shim/app_shim.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

tkent

tapted@, would you approve this please? This solves one of build failures in https://codereview.chromium.org/189703002/#msg7

6 years, 5 months ago (2014-07-16 02:09:57 UTC) #1

tapted

lgtm - thanks. I think we are about to move this whole folder into src/chrome/browser/apps, ...

6 years, 5 months ago (2014-07-16 02:25:19 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/391283002/1

6 years, 5 months ago (2014-07-16 03:03:58 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...

6 years, 5 months ago (2014-07-16 10:07:32 UTC) #5

Message was sent while issue was closed.

Change committed as 283496