Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 391273002: Merge 281795 "base: Add soft memory limit to DiscardableMemoryMa..." (Closed)

Created:
6 years, 5 months ago by reveman
Modified:
6 years, 5 months ago
Reviewers:
reveman
CC:
chromium-reviews, darin-cc_chromium.org, erikwright+watch_chromium.org, jam, gavinp+memory_chromium.org
Project:
chromium
Visibility:
Public.

Description

Merge 281795 "base: Add soft memory limit to DiscardableMemoryMa..." > base: Add soft memory limit to DiscardableMemoryManager. > > This adds a soft memory limit to the discardable memory manager. Only > allocations that haven't been used in specific amount of time are > affected by this limit. This allows a client to use a much higher hard > limit so temporary spikes in required usage can be handled efficiently > without causing an increase in usage while idle. > > A "reduce memory usage" function is added to the discardable memory > interface to allow the client to effectively trigger purging of memory > that is affected by the soft limit when system reaches what would be > considered an idle state. > > BUG=383361, 372158 > TEST=base_unittests --gtest_filter=DiscardableMemoryManagerTest.ReduceMemoryUsage > > Review URL: https://codereview.chromium.org/336273003 TBR=reveman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283286

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+251 lines, -53 lines) Patch
M base/memory/discardable_memory.h View 1 chunk +10 lines, -0 lines 0 comments Download
M base/memory/discardable_memory_android.cc View 2 chunks +9 lines, -1 line 0 comments Download
M base/memory/discardable_memory_emulated.h View 1 chunk +1 line, -0 lines 0 comments Download
M base/memory/discardable_memory_emulated.cc View 2 chunks +8 lines, -1 line 0 comments Download
M base/memory/discardable_memory_linux.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M base/memory/discardable_memory_mac.cc View 2 chunks +10 lines, -1 line 0 comments Download
M base/memory/discardable_memory_manager.h View 7 chunks +46 lines, -13 lines 0 comments Download
M base/memory/discardable_memory_manager.cc View 11 chunks +68 lines, -30 lines 0 comments Download
M base/memory/discardable_memory_manager_unittest.cc View 4 chunks +76 lines, -4 lines 0 comments Download
M base/memory/discardable_memory_win.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 2 chunks +13 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
reveman
6 years, 5 months ago (2014-07-16 00:03:11 UTC) #1
reveman
6 years, 5 months ago (2014-07-16 00:04:49 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r283286.

Powered by Google App Engine
This is Rietveld 408576698