Cast: cast.streaming API to support null audio (or video) track

Cast: cast.streaming API to support null audio (or video) track

Modify the API to accept null audio or video track, both of them cannot
be null however.

This change is to support Cast Streaming for a MediaStream from desktop
capture where there is no audio.

Also changed the authorization for using desktop capture device on non-
official builds. This enables local testing.

Added new API tests.

TEST=browser_tests --gtest_filter=CastStreaming*
BUG=388355
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284244

[Alpha Left Google, 2014-07-15 23:19:52]

Please review.

kalman: extension API changes
miu: cast_rtp_stream.cc

[not at google - send to devlin, 2014-07-15 23:32:18]

https://codereview.chromium.org/391263002/diff/1/chrome/common/extensions/api...
File chrome/common/extensions/api/cast_streaming_session.idl (right):

https://codereview.chromium.org/391263002/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/cast_streaming_session.idl:29: // track then the
created stream ID will be null.
this last sentence doesn't make sense.

https://codereview.chromium.org/391263002/diff/1/chrome/renderer/extensions/c...
File chrome/renderer/extensions/cast_streaming_native_handler.cc (right):

https://codereview.chromium.org/391263002/diff/1/chrome/renderer/extensions/c...
chrome/renderer/extensions/cast_streaming_native_handler.cc:270:
callback_args[0] = v8::Integer::New(isolate, stream1_id);
can you put this up where it's guarded by the if (stream1)? then you won't need
the kInvalidId thing at all, right?

https://codereview.chromium.org/391263002/diff/1/chrome/renderer/extensions/c...
chrome/renderer/extensions/cast_streaming_native_handler.cc:558: v8::Isolate*
isolate = context()->v8_context()->GetIsolate();
this change doesn't seem necessary

[Alpha Left Google, 2014-07-15 23:48:42]

https://codereview.chromium.org/391263002/diff/1/chrome/common/extensions/api...
File chrome/common/extensions/api/cast_streaming_session.idl (right):

https://codereview.chromium.org/391263002/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/cast_streaming_session.idl:29: // track then the
created stream ID will be null.
On 2014/07/15 23:32:18, kalman wrote:
> this last sentence doesn't make sense.

Done.

https://codereview.chromium.org/391263002/diff/1/chrome/renderer/extensions/c...
File chrome/renderer/extensions/cast_streaming_native_handler.cc (right):

https://codereview.chromium.org/391263002/diff/1/chrome/renderer/extensions/c...
chrome/renderer/extensions/cast_streaming_native_handler.cc:270:
callback_args[0] = v8::Integer::New(isolate, stream1_id);
On 2014/07/15 23:32:18, kalman wrote:
> can you put this up where it's guarded by the if (stream1)? then you won't
need
> the kInvalidId thing at all, right?

Done.

https://codereview.chromium.org/391263002/diff/1/chrome/renderer/extensions/c...
chrome/renderer/extensions/cast_streaming_native_handler.cc:558: v8::Isolate*
isolate = context()->v8_context()->GetIsolate();
On 2014/07/15 23:32:18, kalman wrote:
> this change doesn't seem necessary

Done.

[not at google - send to devlin, 2014-07-15 23:55:42]

lgtm but you should look into that null vs undefined thing.

https://codereview.chromium.org/391263002/diff/20001/chrome/renderer/extensio...
File chrome/renderer/extensions/cast_streaming_native_handler.cc (right):

https://codereview.chromium.org/391263002/diff/20001/chrome/renderer/extensio...
chrome/renderer/extensions/cast_streaming_native_handler.cc:202: if
(args[0]->IsNull() && args[1]->IsNull()) {
undefined is an acceptable value for optional arguments, but isNull won't catch
that, and the CHECK on line 212 will fail. I think. unless the JS code is
automatically turning undefined into null for you already, but you should check
that.

if not there might be some v8 helper to check is null-or-undefined, if not, you
could use BooleanValue - kind of a hack.

[miu, 2014-07-16 00:16:22]

lgtm, but please consider kalman's concern and the following nit comment before
commit:

https://codereview.chromium.org/391263002/diff/20001/chrome/renderer/media/ca...
File chrome/renderer/media/cast_rtp_stream.cc (right):

https://codereview.chromium.org/391263002/diff/20001/chrome/renderer/media/ca...
chrome/renderer/media/cast_rtp_stream.cc:549: VLOG(1) <<
"CastRtpStream::ToggleLogging = "
Might as well also indicate in the logging whether |enable| is true/false.

[Alpha Left Google, 2014-07-16 21:47:47]

+dalecurtis for chrome/browser/media

https://codereview.chromium.org/391263002/diff/20001/chrome/renderer/extensio...
File chrome/renderer/extensions/cast_streaming_native_handler.cc (right):

https://codereview.chromium.org/391263002/diff/20001/chrome/renderer/extensio...
chrome/renderer/extensions/cast_streaming_native_handler.cc:202: if
(args[0]->IsNull() && args[1]->IsNull()) {
On 2014/07/15 23:55:42, kalman wrote:
> undefined is an acceptable value for optional arguments, but isNull won't
catch
> that, and the CHECK on line 212 will fail. I think. unless the JS code is
> automatically turning undefined into null for you already, but you should
check
> that.
> 
> if not there might be some v8 helper to check is null-or-undefined, if not,
you
> could use BooleanValue - kind of a hack.

Checked for IsUndefined() now.

[Alpha Left Google, 2014-07-17 18:13:21]

ping dalecurtis.

[DaleCurtis, 2014-07-17 18:35:16]

lgtm

[Alpha Left Google, 2014-07-17 18:35:29]

The CQ bit was checked by hclam@chromium.org

[commit-bot: I haz the power, 2014-07-17 18:38:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hclam@chromium.org/391263002/40001

[commit-bot: I haz the power, 2014-07-17 23:26:13]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-18 00:55:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-18 00:55:55]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[Alpha Left Google, 2014-07-18 19:26:55]

kalman: I've added a property of allowAmbiguousOptionalArguments to idl
compilek. Please take another look.

[not at google - send to devlin, 2014-07-18 20:05:21]

lgtm

[Alpha Left Google, 2014-07-18 20:08:29]

The CQ bit was checked by hclam@chromium.org

[commit-bot: I haz the power, 2014-07-18 20:09:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hclam@chromium.org/391263002/60001

[commit-bot: I haz the power, 2014-07-18 21:48:41]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-07-18 22:20:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-18 22:20:33]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[Alpha Left Google, 2014-07-18 22:53:10]

The CQ bit was checked by hclam@chromium.org

[commit-bot: I haz the power, 2014-07-18 22:54:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hclam@chromium.org/391263002/60001

[commit-bot: I haz the power, 2014-07-18 23:08:19]

Change committed as 284244