Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 391243004: docs for chrome.devtools.panels & inspectedWindow (Closed)

Created:
6 years, 5 months ago by paulirish
Modified:
6 years, 5 months ago
Reviewers:
caseq
Base URL:
https://chromium.googlesource.com/chromium/src@master
Visibility:
Public.

Description

docs for chrome.devtools.panels & inspectedWindow I'm refiling the CL from https://codereview.chromium.org/283603003/ on behalf of mem. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283792

Patch Set 1 : mem's CL from 283603003, last nits addressed #

Total comments: 1

Patch Set 2 : nit on value of result #

Patch Set 3 : fix invalid json #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -4 lines) Patch
M chrome/common/extensions/api/devtools/inspected_window.json View 1 2 4 chunks +59 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/devtools/panels.json View 2 chunks +27 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
paulirish
The LGTM'd patch from https://codereview.chromium.org/283603003/#msg11 now addresses those two nits.
6 years, 5 months ago (2014-07-16 03:01:21 UTC) #1
caseq
lgtm with a nit. https://chromiumcodereview.appspot.com/391243004/diff/1/chrome/common/extensions/api/devtools/inspected_window.json File chrome/common/extensions/api/devtools/inspected_window.json (right): https://chromiumcodereview.appspot.com/391243004/diff/1/chrome/common/extensions/api/devtools/inspected_window.json#newcode91 chrome/common/extensions/api/devtools/inspected_window.json:91: "description": "Evaluates a JavaScript expression ...
6 years, 5 months ago (2014-07-16 06:12:06 UTC) #2
paulirish
The CQ bit was checked by paulirish@chromium.org
6 years, 5 months ago (2014-07-16 06:50:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/paulirish@chromium.org/391243004/20001
6 years, 5 months ago (2014-07-16 06:53:13 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 11:17:17 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-16 11:21:17 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/80232)
6 years, 5 months ago (2014-07-16 11:21:18 UTC) #7
paulirish
The CQ bit was checked by paulirish@chromium.org
6 years, 5 months ago (2014-07-17 10:24:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/paulirish@chromium.org/391243004/40001
6 years, 5 months ago (2014-07-17 10:25:36 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 16:30:53 UTC) #10
Message was sent while issue was closed.
Change committed as 283792

Powered by Google App Engine
This is Rietveld 408576698