Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 391213003: Update and enable PPApiTest.URLLoaderTest3 (Closed)

Created:
6 years, 5 months ago by yhirano
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Update and enable PPApiTest.URLLoaderTest3 The test was disabled[1] when XMLHttpRequest forbidden header names changed[2]. This CL updates and enables it. 1: https://src.chromium.org/viewvc/chrome?view=rev&revision=282507 2: https://src.chromium.org/viewvc/blink?view=rev&revision=178023 BUG=373120 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283709

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M chrome/test/ppapi/ppapi_browsertest.cc View 2 chunks +1 line, -5 lines 0 comments Download
M ppapi/tests/test_url_loader.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
yhirano
6 years, 5 months ago (2014-07-16 08:48:55 UTC) #1
dmichael (off chromium)
lgtm
6 years, 5 months ago (2014-07-16 15:22:44 UTC) #2
yhirano
The CQ bit was checked by yhirano@chromium.org
6 years, 5 months ago (2014-07-16 15:46:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/391213003/1
6 years, 5 months ago (2014-07-16 15:55:12 UTC) #4
yhirano
The CQ bit was unchecked by yhirano@chromium.org
6 years, 5 months ago (2014-07-17 07:40:46 UTC) #5
yhirano
The CQ bit was checked by yhirano@chromium.org
6 years, 5 months ago (2014-07-17 07:40:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/391213003/1
6 years, 5 months ago (2014-07-17 07:41:27 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 08:23:58 UTC) #8
Message was sent while issue was closed.
Change committed as 283709

Powered by Google App Engine
This is Rietveld 408576698