Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 391213002: Fixed TrayBackgroundView::GetBubbleAnchorRect to handle left/right alignment when the tray isn't vi… (Closed)

Created:
6 years, 5 months ago by bruthig
Modified:
6 years, 5 months ago
Reviewers:
jennyz
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fixed TrayBackgroundView::GetBubbleAnchorRect to handle left/right alignment when the tray isn't visible. BUG=392473 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283790

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added handling for failing test use case. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -11 lines) Patch
M ash/system/tray/tray_background_view.cc View 1 2 chunks +42 lines, -11 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
bruthig
jennyz Can you review this for me? https://codereview.chromium.org/391213002/diff/1/ash/system/tray/tray_background_view.cc File ash/system/tray/tray_background_view.cc (right): https://codereview.chromium.org/391213002/diff/1/ash/system/tray/tray_background_view.cc#newcode604 ash/system/tray/tray_background_view.cc:604: DCHECK(false) << ...
6 years, 5 months ago (2014-07-15 21:00:45 UTC) #1
jennyz
lgtm
6 years, 5 months ago (2014-07-15 21:22:04 UTC) #2
bruthig
The CQ bit was checked by bruthig@chromium.org
6 years, 5 months ago (2014-07-16 13:33:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bruthig@chromium.org/391213002/20001
6 years, 5 months ago (2014-07-16 13:33:57 UTC) #4
bruthig
The CQ bit was unchecked by bruthig@chromium.org
6 years, 5 months ago (2014-07-16 13:39:43 UTC) #5
bruthig
The CQ bit was checked by bruthig@chromium.org
6 years, 5 months ago (2014-07-16 18:43:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bruthig@chromium.org/391213002/20001
6 years, 5 months ago (2014-07-16 18:44:40 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 20:50:40 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-16 22:19:11 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/171786)
6 years, 5 months ago (2014-07-16 22:19:12 UTC) #10
bruthig
The CQ bit was checked by bruthig@chromium.org
6 years, 5 months ago (2014-07-17 15:04:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bruthig@chromium.org/391213002/20001
6 years, 5 months ago (2014-07-17 15:05:14 UTC) #12
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 16:19:24 UTC) #13
Message was sent while issue was closed. 
Change committed as 283790

Powered by Google App Engine
This is Rietveld 408576698