tools/findit/utils.py - Issue 391173002: [Findit] Initiate Findit for crash.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/findit/utils.py

Issue 391173002: [Findit] Initiate Findit for crash. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add cacert.pem Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 # Copyright (c) 2011 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 import sys

	6

	7

	8 def GetOSName(platform_name=sys.platform):

	9 if platform_name == 'cygwin' or platform_name.startswith('win'):

	10 return 'win'

	11 elif platform_name.startswith('linux'):

	12 return 'unix'

	13 elif platform_name.startswith('darwin'):

	14 return 'mac'

	15 else:

	16 return platform_name

	17

	18

	19 def IsSvnRevision(revision):

	20 revision = str(revision)

	21 return len(revision) < 8 and revision.isdigit()
	Martin Barbella 2014/07/22 06:35:43 This seems like a hack. It would probably be clean This seems like a hack. It would probably be cleaner to determine that something isn't a git hash based on the length. stgao 2014/07/22 20:30:35 In fact, depot_tools/roll_dep.py also does a check Show quoted text On 2014/07/22 06:35:43, mbarbella wrote: > This seems like a hack. It would probably be cleaner to determine that something > isn't a git hash based on the length. In fact, depot_tools/roll_dep.py also does a check on length, but it could verify the git revision against a local repos checkout. Here, we could do a pattern matching which is more strict then checking the length.
OLD	NEW

« tools/findit/chromium_deps.py ('K') | « tools/findit/run_all_tests.py ('k') | no next file » | no next file with comments »