Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 391153002: Add unique ID to GrPlot (Closed)

Created:
6 years, 5 months ago by robertphillips
Modified:
6 years, 5 months ago
Reviewers:
jvanverth1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add unique ID to GrPlot This is calved off of (Add atlased layer purging - https://codereview.chromium.org/367073002/) where it is used for plot lifetime management (i.e., tracking which plots are locked). Committed: https://skia.googlesource.com/skia/+/17dabfc38d5ecba73845fa11e3cb3a617f52ead0

Patch Set 1 #

Patch Set 2 : Fix initialization list order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -10 lines) Patch
M src/gpu/GrAtlas.h View 2 chunks +6 lines, -1 line 0 comments Download
M src/gpu/GrAtlas.cpp View 1 3 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
robertphillips
6 years, 5 months ago (2014-07-15 16:21:47 UTC) #1
jvanverth1
lgtm
6 years, 5 months ago (2014-07-16 13:42:19 UTC) #2
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 5 months ago (2014-07-16 13:45:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/391153002/1
6 years, 5 months ago (2014-07-16 13:45:40 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Build-Mac10.8-Clang-x86-Release-Trybot on tryserver.skia ...
6 years, 5 months ago (2014-07-16 14:04:30 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-16 14:08:16 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Mac10.8-Clang-x86-Release-Trybot on tryserver.skia (http://108.170.220.76:10117/builders/Build-Mac10.8-Clang-x86-Release-Trybot/builds/1909)
6 years, 5 months ago (2014-07-16 14:08:16 UTC) #7
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 5 months ago (2014-07-16 16:18:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/391153002/20001
6 years, 5 months ago (2014-07-16 16:19:42 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 20:26:30 UTC) #10
Message was sent while issue was closed. 
Change committed as 17dabfc38d5ecba73845fa11e3cb3a617f52ead0

Powered by Google App Engine
This is Rietveld 408576698