chrome/common/extensions/docs/server2/api_data_source.py - Issue 39113003: Docserver: Display enum value descriptions in API docs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/server2/api_data_source.py

Issue 39113003: Docserver: Display enum value descriptions in API docs. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/docs/server2/api_data_source.py

diff --git a/chrome/common/extensions/docs/server2/api_data_source.py b/chrome/common/extensions/docs/server2/api_data_source.py

index a8147e9b39cb1b7ac2dcc7f738692be8374d7061..508eced713b6005fe8e8d5ea254ff9b10c5125bd 100644

--- a/chrome/common/extensions/docs/server2/api_data_source.py

+++ b/chrome/common/extensions/docs/server2/api_data_source.py

@@ -326,11 +326,10 @@ class _JSCModel(object):

elif type_.property_type == model.PropertyType.ARRAY:

dst_dict['array'] = self._GenerateType(type_.item_type)

elif type_.property_type == model.PropertyType.ENUM:

- dst_dict['enum_values'] = []

- for enum_value in type_.enum_values:

- dst_dict['enum_values'].append({'name': enum_value})

+ dst_dict['enum_values'] = type_.enum_values

if len(dst_dict['enum_values']) > 0:

- dst_dict['enum_values'][-1]['last'] = True

+ dst_dict['enum_values'][-1] = dict(dst_dict['enum_values'][-1],

+ last=True)

elif type_.instance_of is not None:

dst_dict['simple_type'] = type_.instance_of.lower()

else: