Issue 391085: Checks if the plugin has gone away inside of HandleURLRequestInternal()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 391085: Checks if the plugin has gone away inside of HandleURLRequestInternal() (Closed)

Created:
11 years, 1 month ago by jamesr

Modified:
9 years, 6 months ago

Reviewers:
jam

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Checks if the plugin has gone away inside of HandleURLRequestInternal() TEST=Set up a plugin to race a destroy call against the sync IPC, run 20 times BUG=27924 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32193

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	webkit/glue/webplugin_impl.cc	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

jamesr

I'll work on getting a test added to plugin_windowless_tests, but it's going to be racy.

11 years, 1 month ago (2009-11-17 01:40:04 UTC) #1

jam

11 years, 1 month ago (2009-11-17 02:21:35 UTC) #2

lgtm

would it be possible to reproduce this consistently in a test?