Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Side by Side Diff: Source/devtools/front_end/network/NetworkPanel.js

Issue 391083003: DevTools: remove Node.reveal() and RemoteOject.reveal() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/devtools/front_end/main/Main.js ('k') | Source/devtools/front_end/sdk/DOMModel.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org> 3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
4 * Copyright (C) 2011 Google Inc. All rights reserved. 4 * Copyright (C) 2011 Google Inc. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 1284 matching lines...) Expand 10 before | Expand all | Expand 10 after
1295 } 1295 }
1296 1296
1297 var request = node._request; 1297 var request = node._request;
1298 var regExp = this._searchRegExp; 1298 var regExp = this._searchRegExp;
1299 var nameMatched = request.name().match(regExp); 1299 var nameMatched = request.name().match(regExp);
1300 var pathMatched = request.path().match(regExp); 1300 var pathMatched = request.path().match(regExp);
1301 if (!nameMatched && pathMatched && !this._largerRequestsButton.toggled) 1301 if (!nameMatched && pathMatched && !this._largerRequestsButton.toggled)
1302 this._toggleLargerRequests(); 1302 this._toggleLargerRequests();
1303 var highlightedSubstringChanges = node._highlightMatchedSubstring(regExp ); 1303 var highlightedSubstringChanges = node._highlightMatchedSubstring(regExp );
1304 this._highlightedSubstringChanges.push(highlightedSubstringChanges); 1304 this._highlightedSubstringChanges.push(highlightedSubstringChanges);
1305 if (reveal) { 1305 if (reveal)
1306 node.reveal(); 1306 WebInspector.Revealer.reveal(node);
1307 this._highlightNode(node);
1308 }
1309 1307
1310 this._currentMatchedRequestNode = node; 1308 this._currentMatchedRequestNode = node;
1311 this._currentMatchedRequestIndex = n; 1309 this._currentMatchedRequestIndex = n;
1312 this.dispatchEventToListeners(WebInspector.NetworkLogView.EventTypes.Sea rchIndexUpdated, n); 1310 this.dispatchEventToListeners(WebInspector.NetworkLogView.EventTypes.Sea rchIndexUpdated, n);
1313 }, 1311 },
1314 1312
1315 /** 1313 /**
1316 * @param {string} query 1314 * @param {string} query
1317 * @param {boolean} shouldJump 1315 * @param {boolean} shouldJump
1318 * @param {boolean=} jumpBackwards 1316 * @param {boolean=} jumpBackwards
(...skipping 1697 matching lines...) Expand 10 before | Expand all | Expand 10 after
3016 WebInspector.NetworkDataGridNode.RequestPropertyComparator = function(propertyNa me, revert, a, b) 3014 WebInspector.NetworkDataGridNode.RequestPropertyComparator = function(propertyNa me, revert, a, b)
3017 { 3015 {
3018 var aValue = a._request[propertyName]; 3016 var aValue = a._request[propertyName];
3019 var bValue = b._request[propertyName]; 3017 var bValue = b._request[propertyName];
3020 if (aValue > bValue) 3018 if (aValue > bValue)
3021 return revert ? -1 : 1; 3019 return revert ? -1 : 1;
3022 if (bValue > aValue) 3020 if (bValue > aValue)
3023 return revert ? 1 : -1; 3021 return revert ? 1 : -1;
3024 return a._request.indentityCompare(b._request); 3022 return a._request.indentityCompare(b._request);
3025 } 3023 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/main/Main.js ('k') | Source/devtools/front_end/sdk/DOMModel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698