Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Side by Side Diff: Source/devtools/front_end/main/Main.js

Issue 391083003: DevTools: remove Node.reveal() and RemoteOject.reveal() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2007 Matt Lilek (pewtermoose@gmail.com). 3 * Copyright (C) 2007 Matt Lilek (pewtermoose@gmail.com).
4 * Copyright (C) 2009 Joseph Pecoraro 4 * Copyright (C) 2009 Joseph Pecoraro
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 545 matching lines...) Expand 10 before | Expand all | Expand 10 after
556 WebInspector.inspectorView.setCurrentPanel(elementsPanel); 556 WebInspector.inspectorView.setCurrentPanel(elementsPanel);
557 return; 557 return;
558 } 558 }
559 559
560 /** 560 /**
561 * @param {!WebInspector.DOMNode} node 561 * @param {!WebInspector.DOMNode} node
562 */ 562 */
563 function callback(node) 563 function callback(node)
564 { 564 {
565 elementsPanel.stopOmittingDefaultSelection(); 565 elementsPanel.stopOmittingDefaultSelection();
566 node.reveal(); 566 WebInspector.Revealer.reveal(node);
567 if (!WebInspector.inspectorView.drawerVisible() && !WebInspector._no tFirstInspectElement) 567 if (!WebInspector.inspectorView.drawerVisible() && !WebInspector._no tFirstInspectElement)
568 InspectorFrontendHost.inspectElementCompleted(); 568 InspectorFrontendHost.inspectElementCompleted();
569 WebInspector._notFirstInspectElement = true; 569 WebInspector._notFirstInspectElement = true;
570 object.release(); 570 object.release();
571 } 571 }
572 572
573 if (object.type === "function") { 573 if (object.type === "function") {
574 /** 574 /**
575 * @param {?Protocol.Error} error 575 * @param {?Protocol.Error} error
576 * @param {!DebuggerAgent.FunctionDetails} response 576 * @param {!DebuggerAgent.FunctionDetails} response
(...skipping 315 matching lines...) Expand 10 before | Expand all | Expand 10 after
892 var targets = WebInspector.targetManager.targets(); 892 var targets = WebInspector.targetManager.targets();
893 for (var i = 0; i < targets.length; ++i) 893 for (var i = 0; i < targets.length; ++i)
894 targets[i].debuggerModel.removeEventListener(WebInspector.DebuggerMo del.Events.DebuggerPaused, this._debuggerPaused, this); 894 targets[i].debuggerModel.removeEventListener(WebInspector.DebuggerMo del.Events.DebuggerPaused, this._debuggerPaused, this);
895 895
896 var debuggerModel = /** @type {!WebInspector.DebuggerModel} */ (event.ta rget); 896 var debuggerModel = /** @type {!WebInspector.DebuggerModel} */ (event.ta rget);
897 WebInspector.context.setFlavor(WebInspector.Target, debuggerModel.target ()); 897 WebInspector.context.setFlavor(WebInspector.Target, debuggerModel.target ());
898 WebInspector.targetManager.unobserveTargets(this); 898 WebInspector.targetManager.unobserveTargets(this);
899 WebInspector.inspectorView.showPanel("sources"); 899 WebInspector.inspectorView.showPanel("sources");
900 } 900 }
901 } 901 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/elements/ElementsPanel.js ('k') | Source/devtools/front_end/network/NetworkPanel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698