Issue 391064: Remove (actually, reverse meaning of) command line flag for desktop notificat...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 391064: Remove (actually, reverse meaning of) command line flag for desktop notificat... (Closed)

Created:
11 years, 1 month ago by John Gregg

Modified:
9 years ago

Reviewers:
Andrew T Wilson (Slow)

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, darin (slow to review), ben+cc_chromium.org, jam, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Remove (actually, reverse meaning of) command line flag for desktop notifications, so that is is available by default in Windows. Security review at http://b/issue?id=2161143 BUG=25975 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31990

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -8 lines)			Patch
M	chrome/browser/notifications/notifications_uitest.cc	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/renderer_host/browser_render_process_host.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 2	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 2	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/renderer/render_thread.cc	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

Andrew T Wilson (Slow)

11 years, 1 month ago (2009-11-14 01:31:01 UTC) #2

On 2009/11/14 01:28:12, John Gregg wrote:
> 
LGTM