Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Unified Diff: chrome/browser/cocoa/bookmark_bubble_controller_unittest.mm

Issue 391057: Fix multi-window bookmark bubble problem.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cocoa/bookmark_bubble_controller_unittest.mm
===================================================================
--- chrome/browser/cocoa/bookmark_bubble_controller_unittest.mm (revision 32026)
+++ chrome/browser/cocoa/bookmark_bubble_controller_unittest.mm (working copy)
@@ -36,11 +36,19 @@
edits_++;
}
+// Tell us (a delegate) which controller it will "own". This sets up
+// the test classes (e.g. simulates what Chromium would do after
+// creating a BookmarkBubbleController).
- (void)setWindowController:(NSWindowController *)controller {
window_ = static_cast<InfoBubbleWindow*>([controller window]);
- EXPECT_TRUE([window_ isKindOfClass:[InfoBubbleWindow class]]);
+ [controller showWindow:self];
}
+// The bubble tells the delegate when it will go away.
+- (void)bubbleWindowWillClose:(NSWindow*)window {
+ // empty
+ }
+
- (BOOL)isWindowClosing {
return [window_ isClosing];
}
« no previous file with comments | « chrome/browser/cocoa/bookmark_bubble_controller.mm ('k') | chrome/browser/cocoa/browser_window_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698