Issue 391053002: MacViews: Remove "redundant" #ifdef guards in ui/base/theme_provider* files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 391053002: MacViews: Remove "redundant" #ifdef guards in ui/base/theme_provider* files (Closed)

Created:
6 years, 5 months ago by tapted

Modified:
6 years, 5 months ago

Reviewers:
sky

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, mac-views-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

MacViews: Remove "redundant" #ifdef guards in ui/base/theme_provider* files Some `#if mac && !views` guards have been here for over a year (since r202283). Mac implies !views so they're currently redundant. But of course MacViews actually needs this code. BUG=390755 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283369

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -4 lines)			Patch
M	ui/base/default_theme_provider.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/base/default_theme_provider_mac.mm	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	ui/base/theme_provider.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/391053002/1

6 years, 5 months ago (2014-07-15 22:14:24 UTC) #4

Message was sent while issue was closed.

Change committed as 283369

Expand Messages | Collapse Messages