Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(988)

Unified Diff: chrome/browser/cocoa/bookmark_button_cell_unittest.mm

Issue 391046: Fix "open all" on a folder node to open only 'marks in that folder,... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/cocoa/bookmark_button_cell.mm ('k') | chrome/browser/cocoa/bookmark_menu.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/bookmark_button_cell_unittest.mm
===================================================================
--- chrome/browser/cocoa/bookmark_button_cell_unittest.mm (revision 32026)
+++ chrome/browser/cocoa/bookmark_button_cell_unittest.mm (working copy)
@@ -4,6 +4,7 @@
#include "base/scoped_nsobject.h"
#import "chrome/browser/cocoa/bookmark_button_cell.h"
+#import "chrome/browser/cocoa/bookmark_menu.h"
#import "chrome/browser/cocoa/cocoa_test_helper.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/platform_test.h"
@@ -31,21 +32,6 @@
EXPECT_TRUE(size.width < 200 && size.height < 200);
}
-// Make sure a cell's menu has the cell itself as the delegate. This
-// is our convention for reusing the context menu across all bookmarks
-// while being unambiguous when used.
-TEST_F(BookmarkButtonCellTest, MenuDelegate) {
- scoped_nsobject<BookmarkButtonCell> cell([[BookmarkButtonCell alloc]
- initTextCell:@"Testing"]);
- EXPECT_FALSE([cell.get() menu]);
-
- scoped_nsobject<NSMenu> menu([[NSMenu alloc] initWithTitle:@"foo"]);
- [cell setMenu:menu.get()];
- EXPECT_TRUE([cell.get() menu]);
- EXPECT_EQ([[cell.get() menu] delegate], cell.get());
- [cell setMenu:nil];
-}
-
// Make sure the default from the base class is overridden
TEST_F(BookmarkButtonCellTest, MouseEnterStuff) {
scoped_nsobject<BookmarkButtonCell> cell([[BookmarkButtonCell alloc]
« no previous file with comments | « chrome/browser/cocoa/bookmark_button_cell.mm ('k') | chrome/browser/cocoa/bookmark_menu.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698