Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Issue 391043003: Revert of Add domain-specific language for BPF policies (Closed)

Created:
6 years, 5 months ago by tapted
Modified:
6 years, 5 months ago
CC:
chromium-reviews, agl, jln+watch_chromium.org, Jorge Lucangeli Obes, Robert Sesek, hamaji, Mark Seaborn, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Revert of Add domain-specific language for BPF policies (https://codereview.chromium.org/299743002/) Reason for revert: Suspected for sandbox_linux_unittests failures on Linux Tests (dbg)(2)(32) at http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29%2832%29/builds/14560 errors in BPFDSL.MoreBooleanLogic Actual test failure: ../../sandbox/linux/bpf_dsl/bpf_dsl_unittest.cc:117:(11) == ((*__errno_location ())) BPFDSL.MaskTest Actual test failure: ../../sandbox/linux/bpf_dsl/bpf_dsl_unittest.cc:206:(expect_errno) == ((*__errno_location ())) BPFDSL.ElseIfTest Actual test failure: ../../sandbox/linux/bpf_dsl/bpf_dsl_unittest.cc:235:(0) == (setuid(0)) output like Value of: subprocess_exit_status Actual: 1 Expected: kExpectedValue Which is: 42 Original issue's description: > Add domain-specific language for BPF policies > > This CL adds basic support for equality testing of system call > arguments, and conjunctive and disjunctive combinations of tests. > > BUG=375497 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283350 TBR=mdempsky@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283377

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -865 lines) Patch
M sandbox/linux/BUILD.gn View 2 chunks +0 lines, -5 lines 0 comments Download
D sandbox/linux/bpf_dsl/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D sandbox/linux/bpf_dsl/bpf_dsl.h View 1 chunk +0 lines, -246 lines 0 comments Download
D sandbox/linux/bpf_dsl/bpf_dsl.cc View 1 chunk +0 lines, -278 lines 0 comments Download
D sandbox/linux/bpf_dsl/bpf_dsl_unittest.cc View 1 chunk +0 lines, -248 lines 0 comments Download
D sandbox/linux/bpf_dsl/cons.h View 1 chunk +0 lines, -46 lines 0 comments Download
D sandbox/linux/bpf_dsl/cons_unittest.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M sandbox/linux/sandbox_linux.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M sandbox/linux/sandbox_linux_test_sources.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tapted
Created Revert of Add domain-specific language for BPF policies
6 years, 5 months ago (2014-07-16 06:57:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/391043003/1
6 years, 5 months ago (2014-07-16 06:58:47 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-16 06:58:48 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 5 months ago (2014-07-16 06:58:48 UTC) #4
tapted
The CQ bit was checked by tapted@chromium.org
6 years, 5 months ago (2014-07-16 07:00:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/391043003/1
6 years, 5 months ago (2014-07-16 07:02:59 UTC) #6
mdempsky
lgtm
6 years, 5 months ago (2014-07-16 07:03:57 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 07:06:01 UTC) #8
Message was sent while issue was closed.
Change committed as 283377

Powered by Google App Engine
This is Rietveld 408576698