Forbid reloading the Inspector window

Forbid reloading the Inspector window.

This CL disables reloading from the system menu, tab popup menu, and page context menu.

BUG=27254, 6902, 23899
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35275

[apavlov, 2009-11-13 14:38:00]

Please review.

[apavlov, 2009-12-24 10:24:42]

Folks, please have another look.

Now the fix uses a more high-level approach (a new Browser::Type, TYPE_DEVTOOLS)
which allows for fine-tuning of features for the DevTools window.

[yurys, 2009-12-24 11:10:59]

http://codereview.chromium.org/391036/diff/5001/6004
File chrome/browser/debugger/devtools_window.cc (right):

http://codereview.chromium.org/391036/diff/5001/6004#newcode196
chrome/browser/debugger/devtools_window.cc:196: browser_ =
Browser::CreateForDevTools(L"DevToolsApp", profile_);
Could you extrace DevToolsApp into a constant and maybe use it directly in
Browser::CreateForDevTools instead of passing it as a parameter

http://codereview.chromium.org/391036/diff/5001/6009
File chrome/browser/tabs/tab_strip_model.h (right):

http://codereview.chromium.org/391036/diff/5001/6009#newcode211
chrome/browser/tabs/tab_strip_model.h:211: virtual bool
CanReloadContents(TabContents* contents) = 0;
placing this method into TabContentsDelegate would be more logical

[apavlov, 2009-12-24 12:00:18]

http://codereview.chromium.org/391036/diff/5001/6004
File chrome/browser/debugger/devtools_window.cc (right):

http://codereview.chromium.org/391036/diff/5001/6004#newcode196
chrome/browser/debugger/devtools_window.cc:196: browser_ =
Browser::CreateForDevTools(L"DevToolsApp", profile_);
On 2009/12/24 11:11:00, Yury Semikhatsky wrote:
> Could you extrace DevToolsApp into a constant and maybe use it directly in
> Browser::CreateForDevTools instead of passing it as a parameter

Done.

http://codereview.chromium.org/391036/diff/5001/6009
File chrome/browser/tabs/tab_strip_model.h (right):

http://codereview.chromium.org/391036/diff/5001/6009#newcode211
chrome/browser/tabs/tab_strip_model.h:211: virtual bool
CanReloadContents(TabContents* contents) = 0;
On 2009/12/24 11:11:00, Yury Semikhatsky wrote:
> placing this method into TabContentsDelegate would be more logical

Done.

[yurys, 2009-12-25 10:13:30]

On 2009/12/24 12:00:18, apavlov wrote:
> http://codereview.chromium.org/391036/diff/5001/6004
> File chrome/browser/debugger/devtools_window.cc (right):
> 
> http://codereview.chromium.org/391036/diff/5001/6004#newcode196
> chrome/browser/debugger/devtools_window.cc:196: browser_ =
> Browser::CreateForDevTools(L"DevToolsApp", profile_);
> On 2009/12/24 11:11:00, Yury Semikhatsky wrote:
> > Could you extrace DevToolsApp into a constant and maybe use it directly in
> > Browser::CreateForDevTools instead of passing it as a parameter
> 
> Done.
> 
> http://codereview.chromium.org/391036/diff/5001/6009
> File chrome/browser/tabs/tab_strip_model.h (right):
> 
> http://codereview.chromium.org/391036/diff/5001/6009#newcode211
> chrome/browser/tabs/tab_strip_model.h:211: virtual bool
> CanReloadContents(TabContents* contents) = 0;
> On 2009/12/24 11:11:00, Yury Semikhatsky wrote:
> > placing this method into TabContentsDelegate would be more logical
> 
> Done.

LGTM

[pfeldman, 2009-12-25 15:22:59]

http://codereview.chromium.org/391036/diff/8001/9007
File chrome/browser/tab_contents/render_view_context_menu.cc (right):

http://codereview.chromium.org/391036/diff/8001/9007#newcode13
chrome/browser/tab_contents/render_view_context_menu.cc:13: #include
"chrome/browser/browser.h"
Why new import? Context menu should not be browser-aware if possible.

http://codereview.chromium.org/391036/diff/8001/9009
File chrome/browser/tabs/tab_strip_model.cc (right):

http://codereview.chromium.org/391036/diff/8001/9009#newcode507
chrome/browser/tabs/tab_strip_model.cc:507: if (TabContents* contents =
GetTabContentsAt(context_index)) {
Do not use { } with single line statements.

http://codereview.chromium.org/391036/diff/8001/9009#newcode507
chrome/browser/tabs/tab_strip_model.cc:507: if (TabContents* contents =
GetTabContentsAt(context_index)) {
No need to check tab contents for being NULL.