Issue 391027: Fix mediator_thread_impl.cc to run timer tasks when the task runner is...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 391027: Fix mediator_thread_impl.cc to run timer tasks when the task runner is... (Closed)

Created:
11 years, 1 month ago by Zachary Kuznia

Modified:
9 years, 7 months ago

Reviewers:
tim (not reviewing)

CC:
chromium-reviews_googlegroups.com, ncarter (slow), fbarchard, Alpha Left Google, idana, awong, ben+cc_chromium.org, tim (not reviewing), scherkus (not reviewing)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix mediator_thread_impl.cc to run timer tasks when the task runner is otherwise idle. BUG=19784, 26988 TEST=1. Enable sync and log in. 2. Go to about:sync 3. Check that notifications are enabled. 4. Disable all network adapters, and wait 15 seconds. 5. Refresh about:sync, and ensure that notifications are disabled. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31820

Patch Set 1 #

Total comments: 1

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -9 lines)			Patch
	M	chrome/browser/sync/notifier/listener/mediator_thread_impl.cc	View		1 chunk	+10 lines, -9 lines	0 comments	Download
	M	third_party/libjingle/files/talk/base/taskrunner.h	View		1 chunk	+5 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tim (not reviewing)

11 years, 1 month ago (2009-11-12 19:42:53 UTC) #2

LGTM

http://codereview.chromium.org/391027/diff/1/2
File third_party/libjingle/files/talk/base/taskrunner.h (right):

http://codereview.chromium.org/391027/diff/1/2#newcode66
Line 66: next_timeout_task_->TimedOut();
nit - indent 2 more.

Expand Messages | Collapse Messages