Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 391012: Split long running test... (Closed)

Created:
11 years, 1 month ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Split long running test Split a long running test into two parts. The second part still takes most of the time and is skipped on ARM in debug mode. BUG=http://code.google.com/p/v8/issues/detail?id=500 Committed: http://code.google.com/p/v8/source/detail?r=3278

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -144 lines) Patch
M test/mjsunit/mjsunit.status View 1 chunk +2 lines, -2 lines 3 comments Download
D test/mjsunit/string-indexof.js View 1 chunk +0 lines, -142 lines 0 comments Download
A test/mjsunit/string-indexof-1.js View 1 chunk +99 lines, -0 lines 0 comments Download
A test/mjsunit/string-indexof-2.js View 1 chunk +68 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Søren Thygesen Gjesse
11 years, 1 month ago (2009-11-11 09:20:33 UTC) #1
Christian Plesner Hansen
JABACABADABACABA http://codereview.chromium.org/391012/diff/1/3 File test/mjsunit/mjsunit.status (right): http://codereview.chromium.org/391012/diff/1/3#newcode66 Line 66: string-indexof-2: PASS, SKIP if $mode == debug ...
11 years, 1 month ago (2009-11-11 09:32:19 UTC) #2
Søren Thygesen Gjesse
http://codereview.chromium.org/391012/diff/1/3 File test/mjsunit/mjsunit.status (right): http://codereview.chromium.org/391012/diff/1/3#newcode66 Line 66: string-indexof-2: PASS, SKIP if $mode == debug On ...
11 years, 1 month ago (2009-11-11 09:39:39 UTC) #3
Christian Plesner Hansen
11 years, 1 month ago (2009-11-11 09:48:44 UTC) #4
http://codereview.chromium.org/391012/diff/1/3
File test/mjsunit/mjsunit.status (right):

http://codereview.chromium.org/391012/diff/1/3#newcode66
Line 66: string-indexof-2: PASS, SKIP if $mode == debug
I see.  That's confusing -- who came up with this stupid way of specifying test
expectations?!?

Powered by Google App Engine
This is Rietveld 408576698