Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1687)

Unified Diff: Source/platform/heap/Heap.h

Issue 390983010: Fix Deque.swap for deques with inline capacity Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Use more fullnesses in test to improve coverage Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/wtf/Deque.h » ('j') | Source/wtf/Deque.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/heap/Heap.h
diff --git a/Source/platform/heap/Heap.h b/Source/platform/heap/Heap.h
index 81bf4ad0cf68eb27e6c72f982c2e110a0707790b..175f5c6bbf53d1707dec3b1698462d5f878f2cbd 100644
--- a/Source/platform/heap/Heap.h
+++ b/Source/platform/heap/Heap.h
@@ -1684,15 +1684,13 @@ public:
{
}
- // FIXME: Doesn't work if there is an inline buffer, due to crbug.com/360572
- HeapDeque<T, 0>& operator=(const HeapDeque& other)
+ HeapDeque& operator=(const HeapDeque& other)
{
HeapDeque<T> copy(other);
swap(copy);
return *this;
}
- // FIXME: Doesn't work if there is an inline buffer, due to crbug.com/360572
inline void swap(HeapDeque& other)
{
Deque<T, inlineCapacity, HeapAllocator>::swap(other);
« no previous file with comments | « no previous file | Source/wtf/Deque.h » ('j') | Source/wtf/Deque.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698