Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issue 390983008: Fix back button does not disconnect remoting session (Closed)

Created:
6 years, 5 months ago by kelvinp
Modified:
6 years, 5 months ago
Reviewers:
Sergey Ulanov, Lambros
CC:
chromium-reviews, chromoting-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fix back button does not disconnect remoting session This is a regression of change r278331. We should let the default dispatchKeyEvent handler to handle KEYCODE_BACK instead of forwarding it to the host. BUG=393055 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283341

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M remoting/android/java/src/org/chromium/chromoting/Desktop.java View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kelvinp
PTAL
6 years, 5 months ago (2014-07-15 03:15:22 UTC) #1
Lambros
lgtm, but please wait for Sergey's opinion - I'm not sure what the proper semantics ...
6 years, 5 months ago (2014-07-15 18:40:21 UTC) #2
kelvinp
The CQ bit was checked by kelvinp@chromium.org
6 years, 5 months ago (2014-07-15 18:42:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kelvinp@chromium.org/390983008/20001
6 years, 5 months ago (2014-07-15 18:44:26 UTC) #4
Sergey Ulanov
lgtm
6 years, 5 months ago (2014-07-15 19:36:37 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 04:53:48 UTC) #6
Message was sent while issue was closed.
Change committed as 283341

Powered by Google App Engine
This is Rietveld 408576698