Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issue 390983006: Cleanup dependency on webkit_common target. (Closed)

Created:
6 years, 5 months ago by tfarina
Modified:
6 years, 5 months ago
Reviewers:
jamesr
CC:
chromium-reviews, darin-cc_chromium.org, jam, android-webview-reviews_chromium.org, darin (slow to review)
Project:
chromium
Visibility:
Public.

Description

Cleanup dependency on webkit_common target. Only content/common and webkit/common/blob/ include from webkit/common/data_element.h and thus need to depend on webkit_common target. BUG=338338 TEST=None R=jamesr@chromium.org TBR=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283681

Patch Set 1 #

Patch Set 2 : add some missing deps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M android_webview/native/webview_native.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_renderer.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/nacl.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_browser.gypi View 1 2 chunks +1 line, -1 line 0 comments Download
M content/content_renderer.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_shell.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/child/webkit_child.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
tfarina
Is this fine? I did: $ g gs webkit/common/data_element. and then $ g gs webkit_common.gyp: ...
6 years, 5 months ago (2014-07-15 00:42:52 UTC) #1
jamesr
Hm, let's see what trybots think...
6 years, 5 months ago (2014-07-15 00:43:57 UTC) #2
tfarina
On 2014/07/15 00:43:57, jamesr wrote: > Hm, let's see what trybots think... Do you trust ...
6 years, 5 months ago (2014-07-15 22:25:35 UTC) #3
jamesr
That should be good - they build the targets that this would probably break. lgtm
6 years, 5 months ago (2014-07-15 22:34:03 UTC) #4
tfarina
TBRing Darin for everything...
6 years, 5 months ago (2014-07-17 00:23:04 UTC) #5
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 5 months ago (2014-07-17 00:23:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/390983006/20001
6 years, 5 months ago (2014-07-17 00:28:47 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-17 05:22:14 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 07:10:12 UTC) #9
Message was sent while issue was closed.
Change committed as 283681

Powered by Google App Engine
This is Rietveld 408576698