Issue 390983004: Merge 281172 "Windows: Add an "Open in Adobe Reader" menu item f..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 390983004: Merge 281172 "Windows: Add an "Open in Adobe Reader" menu item f..." (Closed)

Created:
6 years, 5 months ago by Lei Zhang

Modified:
6 years, 5 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews, benjhayden+dwatch_chromium.org, asanka

Base URL:
svn://svn.chromium.org/chrome/branches/2062/src/

Project:
chromium

Visibility:
Public.

Merge 281172 "Windows: Add an "Open in Adobe Reader" menu item f..." > Windows: Add an "Open in Adobe Reader" menu item for PDF files in the download shelf. > > BUG=370746 > > Review URL: https://codereview.chromium.org/324593004 TBR=thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283045

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+318 lines, -135 lines)			Patch
M	chrome/browser/download/chrome_download_manager_delegate.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/download/chrome_download_manager_delegate.cc	View	2 chunks	+32 lines, -23 lines	0 comments	Download
M	chrome/browser/download/download_prefs.h	View	2 chunks	+13 lines, -0 lines	0 comments	Download
M	chrome/browser/download/download_prefs.cc	View	8 chunks	+44 lines, -1 line	0 comments	Download
M	chrome/browser/download/download_shelf_context_menu.h	View	3 chunks	+12 lines, -0 lines	0 comments	Download
M	chrome/browser/download/download_shelf_context_menu.cc	View	12 chunks	+70 lines, -14 lines	0 comments	Download
M	chrome/browser/download/download_target_determiner.h	View	3 chunks	+23 lines, -1 line	0 comments	Download
M	chrome/browser/download/download_target_determiner.cc	View	7 chunks	+61 lines, -5 lines	0 comments	Download
A +	chrome/browser/ui/pdf/adobe_reader_info_win.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/ui/pdf/adobe_reader_info_win.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/browser/ui/pdf/pdf_unsupported_feature.cc	View	8 chunks	+51 lines, -93 lines	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/common/pref_names.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/common/pref_names.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r283045.