Issue 390983002: Add ash to the GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 390983002: Add ash to the GN build. (Closed)

Created:
6 years, 5 months ago by brettw

Modified:
6 years, 5 months ago

Reviewers:
sky

CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Add ash to the GN build. Minor fixes to ash.gyp: remove tabs, convert sources/ excludes to sources!. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283415

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1282 lines, -904 lines)			Patch
M	BUILD.gn	View	1 2	2 chunks	+3 lines, -1 line	0 comments	Download
M	ash/BUILD.gn	View	1 2	1 chunk	+353 lines, -3 lines	0 comments	Download
M	ash/ash.gyp	View	1 2	14 chunks	+922 lines, -900 lines	0 comments	Download
M	build/config/linux/BUILD.gn	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

brettw

6 years, 5 months ago (2014-07-16 17:50:14 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r283415 (presubmit successful).