Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 390933002: nanobench: support --outResultsFile (Closed)

Created:
6 years, 5 months ago by mtklein_C
Modified:
6 years, 5 months ago
Reviewers:
kelvinly, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

nanobench: support --outResultsFile BUG=skia: Committed: https://skia.googlesource.com/skia/+/60317d0ffb5053df7b08a627d6decd11b684e80d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
M bench/nanobench.cpp View 5 chunks +40 lines, -0 lines 0 comments Download
M gyp/bench.gyp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mtklein
I chickened out. Just using the existing ResultsWriter code for now.
6 years, 5 months ago (2014-07-14 17:44:15 UTC) #1
kelvinly
On 2014/07/14 17:44:15, mtklein wrote: > I chickened out. Just using the existing ResultsWriter code ...
6 years, 5 months ago (2014-07-14 17:53:00 UTC) #2
kelvinly
On 2014/07/14 17:53:00, kelvinly wrote: > On 2014/07/14 17:44:15, mtklein wrote: > > I chickened ...
6 years, 5 months ago (2014-07-14 17:57:05 UTC) #3
mtklein
> Also you're missing the builderName/gitNumber/commitHash flags, but I'm guessing > that was part of ...
6 years, 5 months ago (2014-07-14 17:58:32 UTC) #4
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 5 months ago (2014-07-14 18:14:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/390933002/1
6 years, 5 months ago (2014-07-14 18:15:35 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 18:30:41 UTC) #7
Message was sent while issue was closed.
Change committed as 60317d0ffb5053df7b08a627d6decd11b684e80d

Powered by Google App Engine
This is Rietveld 408576698