Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 390893003: Enable media in default GN build -- Part Deux! (Closed)

Created:
6 years, 5 months ago by DaleCurtis
Modified:
6 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews, feature-media-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Enable media in default GN build -- Part Deux! Previous submission was missing enough of the android portion to prevent passing of compilation. This patch combines ajwong@'s previous work with enough fixes to the Android build to get it working. BUG=none TEST=passes GN, compiles. R=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283477

Patch Set 1 : Rebase. #

Patch Set 2 : Fix widevine. #

Total comments: 2

Patch Set 3 : Fix webview. #

Patch Set 4 : Rebase. #

Patch Set 5 : Fix import. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -66 lines) Patch
M BUILD.gn View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M DEPS View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M media/BUILD.gn View 1 2 3 4 14 chunks +151 lines, -65 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
DaleCurtis
brettw: Please review the new android section at the bottom of media/BUILD.gn the rest is ...
6 years, 5 months ago (2014-07-14 17:54:29 UTC) #1
DaleCurtis
Requires https://codereview.chromium.org/391793002/ to fix skia linking issues. Not sure if GN proper is missing some ...
6 years, 5 months ago (2014-07-14 18:45:51 UTC) #2
brettw
If Android is not forthcoming, just check it in disabled on Android like most of ...
6 years, 5 months ago (2014-07-14 19:24:24 UTC) #3
DaleCurtis
Should build after the skia fix lands. At least it does locally now. I'll CQ ...
6 years, 5 months ago (2014-07-14 21:00:06 UTC) #4
DaleCurtis
Ping. Try on PS#3 (PS#4 is rebase) passed build.
6 years, 5 months ago (2014-07-15 21:56:54 UTC) #5
brettw
lgtm
6 years, 5 months ago (2014-07-15 23:53:42 UTC) #6
DaleCurtis
The CQ bit was checked by dalecurtis@chromium.org
6 years, 5 months ago (2014-07-15 23:58:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/390893003/80001
6 years, 5 months ago (2014-07-16 00:02:43 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 08:15:38 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-16 08:19:21 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel/builds/26211)
6 years, 5 months ago (2014-07-16 08:19:22 UTC) #11
DaleCurtis
The CQ bit was checked by dalecurtis@chromium.org
6 years, 5 months ago (2014-07-16 17:44:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/390893003/80001
6 years, 5 months ago (2014-07-16 17:46:05 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 17:51:33 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-16 17:58:18 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel/builds/26338)
6 years, 5 months ago (2014-07-16 17:58:20 UTC) #16
DaleCurtis
6 years, 5 months ago (2014-07-16 20:14:11 UTC) #17
Message was sent while issue was closed.
Committed patchset #5 manually as r283477 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698