Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 390873002: Constify metrics list references in SVGTextLayoutEngine (Closed)

Created:
6 years, 5 months ago by fs
Modified:
6 years, 5 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, pdr., rwlbuis, Stephen Chennney, rune+blink
Project:
blink
Visibility:
Public.

Description

Constify metrics list references in SVGTextLayoutEngine The text layout engine should not mutate the metrics list, so make the various references to it const to clarify this a bit. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178082

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M Source/core/rendering/svg/SVGTextLayoutEngine.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/SVGTextLayoutEngine.cpp View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
fs
More const-churn trivialities...
6 years, 5 months ago (2014-07-14 15:56:31 UTC) #1
f(malita)
lgtm
6 years, 5 months ago (2014-07-14 16:00:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/390873002/1
6 years, 5 months ago (2014-07-14 16:01:35 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-14 17:07:39 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 17:39:04 UTC) #5
Message was sent while issue was closed.
Change committed as 178082

Powered by Google App Engine
This is Rietveld 408576698