Issue 390873002: Constify metrics list references in SVGTextLayoutEngine

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 390873002: Constify metrics list references in SVGTextLayoutEngine (Closed)

Created:
6 years, 5 months ago by fs

Modified:
6 years, 5 months ago

Reviewers:
pdr., f(malita), Stephen Chennney

CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, pdr., rwlbuis, Stephen Chennney, rune+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Constify metrics list references in SVGTextLayoutEngine The text layout engine should not mutate the metrics list, so make the various references to it const to clarify this a bit. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178082

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -7 lines)			Patch
	M	Source/core/rendering/svg/SVGTextLayoutEngine.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	Source/core/rendering/svg/SVGTextLayoutEngine.cpp	View		5 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/390873002/1

6 years, 5 months ago (2014-07-14 16:01:35 UTC) #3

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...

6 years, 5 months ago (2014-07-14 17:07:39 UTC) #4

Message was sent while issue was closed.

Change committed as 178082

Expand Messages | Collapse Messages