Issue 390843002: Revert 282925 "Make the policy fetch for first time login blocking"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 390843002: Revert 282925 "Make the policy fetch for first time login blocking" (Closed)

Created:
6 years, 5 months ago by kustermann

Modified:
6 years, 5 months ago

Reviewers:
kaliamoorthi

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 282925 "Make the policy fetch for first time login blocking" > Make the policy fetch for first time login blocking > > The CL makes policy fetching for first time login blocking for all users, except the ones that are known to be non-enterprise users. > > BUG=334584 > > Review URL: https://codereview.chromium.org/330843002 Reason for revert: The "Linux Chromium OS ASan LSan Tests (3)" tester found memory leaks. TBR=kaliamoorthi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282942

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+63 lines, -255 lines)			Patch
M	trunk/src/chrome/browser/chromeos/login/login_utils_browsertest.cc	View	4 chunks	+58 lines, -44 lines	0 comments	Download
M	trunk/src/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
D	trunk/src/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_browsertest.cc	View	1 chunk	+0 lines, -187 lines	0 comments	Download
M	trunk/src/chrome/browser/chromeos/policy/user_cloud_policy_manager_factory_chromeos.cc	View	5 chunks	+3 lines, -13 lines	0 comments	Download
M	trunk/src/chrome/chrome_tests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/chrome/test/base/in_process_browser_test.h	View	2 chunks	+0 lines, -7 lines	0 comments	Download
M	trunk/src/chrome/test/base/in_process_browser_test.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

kustermann

6 years, 5 months ago (2014-07-14 14:07:41 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r282942 (tree was closed).