Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Side by Side Diff: src/objects-inl.h

Issue 390833003: Remove PropertyAttributes from SetProperty (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.cc ('k') | src/runtime.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 1143 matching lines...) Expand 10 before | Expand all | Expand 10 after
1154 } 1154 }
1155 1155
1156 1156
1157 MaybeHandle<Object> JSProxy::SetElementWithHandler(Handle<JSProxy> proxy, 1157 MaybeHandle<Object> JSProxy::SetElementWithHandler(Handle<JSProxy> proxy,
1158 Handle<JSReceiver> receiver, 1158 Handle<JSReceiver> receiver,
1159 uint32_t index, 1159 uint32_t index,
1160 Handle<Object> value, 1160 Handle<Object> value,
1161 StrictMode strict_mode) { 1161 StrictMode strict_mode) {
1162 Isolate* isolate = proxy->GetIsolate(); 1162 Isolate* isolate = proxy->GetIsolate();
1163 Handle<String> name = isolate->factory()->Uint32ToString(index); 1163 Handle<String> name = isolate->factory()->Uint32ToString(index);
1164 return SetPropertyWithHandler( 1164 return SetPropertyWithHandler(proxy, receiver, name, value, strict_mode);
1165 proxy, receiver, name, value, NONE, strict_mode);
1166 } 1165 }
1167 1166
1168 1167
1169 bool JSProxy::HasElementWithHandler(Handle<JSProxy> proxy, uint32_t index) { 1168 bool JSProxy::HasElementWithHandler(Handle<JSProxy> proxy, uint32_t index) {
1170 Isolate* isolate = proxy->GetIsolate(); 1169 Isolate* isolate = proxy->GetIsolate();
1171 Handle<String> name = isolate->factory()->Uint32ToString(index); 1170 Handle<String> name = isolate->factory()->Uint32ToString(index);
1172 return HasPropertyWithHandler(proxy, name); 1171 return HasPropertyWithHandler(proxy, name);
1173 } 1172 }
1174 1173
1175 1174
(...skipping 5994 matching lines...) Expand 10 before | Expand all | Expand 10 after
7170 #undef READ_SHORT_FIELD 7169 #undef READ_SHORT_FIELD
7171 #undef WRITE_SHORT_FIELD 7170 #undef WRITE_SHORT_FIELD
7172 #undef READ_BYTE_FIELD 7171 #undef READ_BYTE_FIELD
7173 #undef WRITE_BYTE_FIELD 7172 #undef WRITE_BYTE_FIELD
7174 #undef NOBARRIER_READ_BYTE_FIELD 7173 #undef NOBARRIER_READ_BYTE_FIELD
7175 #undef NOBARRIER_WRITE_BYTE_FIELD 7174 #undef NOBARRIER_WRITE_BYTE_FIELD
7176 7175
7177 } } // namespace v8::internal 7176 } } // namespace v8::internal
7178 7177
7179 #endif // V8_OBJECTS_INL_H_ 7178 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | src/runtime.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698