Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Side by Side Diff: src/log-utils.cc

Issue 390803002: Ensure that each profiling entry ends with a new line. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/log.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/log-utils.h" 7 #include "src/log-utils.h"
8 #include "src/string-stream.h" 8 #include "src/string-stream.h"
9 9
10 namespace v8 { 10 namespace v8 {
(...skipping 201 matching lines...) Expand 10 before | Expand all | Expand 10 after
212 Vector<char> buf(log_->message_buffer_ + pos_, 212 Vector<char> buf(log_->message_buffer_ + pos_,
213 Log::kMessageBufferSize - pos_); 213 Log::kMessageBufferSize - pos_);
214 StrNCpy(buf, str, len); 214 StrNCpy(buf, str, len);
215 pos_ += len; 215 pos_ += len;
216 ASSERT(pos_ <= Log::kMessageBufferSize); 216 ASSERT(pos_ <= Log::kMessageBufferSize);
217 } 217 }
218 218
219 219
220 void Log::MessageBuilder::WriteToLogFile() { 220 void Log::MessageBuilder::WriteToLogFile() {
221 ASSERT(pos_ <= Log::kMessageBufferSize); 221 ASSERT(pos_ <= Log::kMessageBufferSize);
222 // Assert that we do not already have a new line at the end.
223 ASSERT(pos_ == 0 || log_->message_buffer_[pos_ - 1] != '\n');
224 if (pos_ == Log::kMessageBufferSize) pos_--;
225 log_->message_buffer_[pos_++] = '\n';
222 const int written = log_->WriteToFile(log_->message_buffer_, pos_); 226 const int written = log_->WriteToFile(log_->message_buffer_, pos_);
223 if (written != pos_) { 227 if (written != pos_) {
224 log_->stop(); 228 log_->stop();
225 log_->logger_->LogFailure(); 229 log_->logger_->LogFailure();
226 } 230 }
227 } 231 }
228 232
229 233
230 } } // namespace v8::internal 234 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/log.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698