Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Issue 390783003: Fix error message about read-only symbol properties. (Closed)

Created:
6 years, 5 months ago by Michael Starzinger
Modified:
6 years, 5 months ago
Reviewers:
rossberg
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix error message about read-only symbol properties. R=rossberg@chromium.org BUG=v8:3441 LOG=Y Committed: https://code.google.com/p/v8/source/detail?r=22377

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/messages.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
I could add a regression test for this to the "messages" test suite, not sure ...
6 years, 5 months ago (2014-07-14 11:33:53 UTC) #1
rossberg
LGTM > I could add a regression test for this to the "messages" test suite, ...
6 years, 5 months ago (2014-07-14 12:28:19 UTC) #2
Michael Starzinger
6 years, 5 months ago (2014-07-14 13:57:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22377 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698