[WebSocket] Send a close frame when the renderer process is gone.

content/browser/renderer_host/websocket_dispatcher_host.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/websocket_dispatcher_host.h"
 
+#include <hash_map>

[Adam Rice, 2014/07/14 05:41:50]

I think the lint warning that tells you to include this is wrong. The
"base/hash_map.h" include file will pull in the correct platform-specific
include.

[yhirano, 2014/07/14 09:27:20]

Thanks, done

 #include <string>
+#include <vector>
 
 #include "base/callback.h"
 #include "base/logging.h"
 #include "base/stl_util.h"
 #include "content/browser/child_process_security_policy_impl.h"
 #include "content/browser/renderer_host/websocket_host.h"
 #include "content/common/websocket_messages.h"
 
 namespace content {
 
@@ skipping 153 matching lines @@
     const std::string& reason) {
   if (SendOrDrop(
           new WebSocketMsg_DropChannel(routing_id, was_clean, code, reason)) ==
       WEBSOCKET_HOST_DELETED)
     return WEBSOCKET_HOST_DELETED;
   DeleteWebSocketHost(routing_id);
   return WEBSOCKET_HOST_DELETED;
 }
 
 WebSocketDispatcherHost::~WebSocketDispatcherHost() {
+  std::vector<WebSocketHost*> hosts;
+  for (base::hash_map<int, WebSocketHost*>::const_iterator i = hosts_.begin();
+       i != hosts_.end(); ++i) {
+    // In order to avoid changing a container while iterating, we copy hosts.

[Adam Rice, 2014/07/14 05:41:49]

s/a container/the container/
s/copy hosts/copy the hosts/

[yhirano, 2014/07/14 09:27:20]

Done.

+    hosts.push_back(i->second);
+  }
+
+  for (size_t i = 0; i < hosts.size(); ++i) {
+    // Note that some GoAway could fail. In that case hosts[i] will be

[Adam Rice, 2014/07/14 05:41:49]

s/some GoAway/some calls to GoAway/

[yhirano, 2014/07/14 09:27:20]

Done.

+    // deleted and removed in |DoDropChannel|.
+    hosts[i]->GoAway();
+    hosts[i] = NULL;
+  }
+
   STLDeleteContainerPairSecondPointers(hosts_.begin(), hosts_.end());
 }
 
 void WebSocketDispatcherHost::DeleteWebSocketHost(int routing_id) {
   WebSocketHostTable::iterator it = hosts_.find(routing_id);
   DCHECK(it != hosts_.end());
   delete it->second;
   hosts_.erase(it);
 }
 
 }  // namespace content