Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 390763004: Make the policy fetch for first time login blocking (Closed)

Created:
6 years, 5 months ago by kaliamoorthi
Modified:
6 years, 5 months ago
Reviewers:
Joao da Silva
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make the policy fetch for first time login blocking The CL makes policy fetching for first time login blocking for all users, except the ones that are known to be non-enterprise users. This CL has the same contest as https://codereview.chromium.org/330843002/ with a code rebase TBR=joaodasilva@chromium.org BUG=334584 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283432

Patch Set 1 : Rebase on top of issue 330843002 #

Patch Set 2 : Modified existing leak suppression to account for symbol changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+256 lines, -64 lines) Patch
M chrome/browser/chromeos/login/login_utils_browsertest.cc View 4 chunks +44 lines, -58 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_browsertest.cc View 1 chunk +187 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_manager_factory_chromeos.cc View 5 chunks +13 lines, -3 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/base/in_process_browser_test.h View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 2 chunks +2 lines, -1 line 0 comments Download
M tools/lsan/suppressions.txt View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
kaliamoorthi
6 years, 5 months ago (2014-07-15 09:05:19 UTC) #1
Joao da Silva
lgtm Add a TBR=joaodasilva@chromium.org line so that you can send this to the CQ.
6 years, 5 months ago (2014-07-15 09:09:32 UTC) #2
kaliamoorthi
The CQ bit was checked by kaliamoorthi@chromium.org
6 years, 5 months ago (2014-07-15 13:42:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaliamoorthi@chromium.org/390763004/20001
6 years, 5 months ago (2014-07-15 13:44:20 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win8_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-15 19:36:07 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-15 23:19:14 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/builds/3689)
6 years, 5 months ago (2014-07-15 23:19:15 UTC) #7
kaliamoorthi
The CQ bit was checked by kaliamoorthi@chromium.org
6 years, 5 months ago (2014-07-16 09:24:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaliamoorthi@chromium.org/390763004/20001
6 years, 5 months ago (2014-07-16 09:26:01 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 18:04:47 UTC) #10
Message was sent while issue was closed. 
Change committed as 283432

Powered by Google App Engine
This is Rietveld 408576698